GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127146: Enable large files on Emscripten by hoodmane · Pull Request #135635 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Jun 17, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is fully supported by Emscripten for a long time. Fixes tests: test_zipimport.CompressedZipImportTestCase.testZip64LargeFile test_zipimport.UncompressedZipImportTestCase.testZip64LargeFile

  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hoodmane
pythongh-127146: Enable large files on Emscripten
85c52c3
This is fully supported by Emscripten for a long time. Fixes tests:
test_zipimport.CompressedZipImportTestCase.testZip64LargeFile
test_zipimport.UncompressedZipImportTestCase.testZip64LargeFile
@hoodmane hoodmane assigned freakboy3742 Jun 17, 2025
@hoodmane
hoodmane requested review from corona10 and erlend-aasland as code owners June 17, 2025 18:43
@hoodmane hoodmane added the skip news label Jun 17, 2025
@bedevere-app bedevere-app Bot added the awaiting review label Jun 17, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 17, 2025
Emscripten: Get test suite passing #127146
Closed
@freakboy3742 freakboy3742 added the needs backport to 3.14 bugs and security fixes label Jun 17, 2025
@freakboy3742
Merge branch 'main' into emscripten-large-files
848fda7
freakboy3742
freakboy3742 approved these changes Jun 18, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 18, 2025
@freakboy3742
freakboy3742 enabled auto-merge (squash) June 18, 2025 03:51
@freakboy3742
freakboy3742 merged commit 01c80b2 into python:main Jun 18, 2025
@miss-islington-app

miss-islington-app Bot commented Jun 18, 2025

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 18, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2025
@hoodmane @miss-islington
pythongh-127146: Enable large files on Emscripten (pythonGH-135635)
7cc1d8a
Large files have been fully supported by Emscripten for a long time.
(cherry picked from commit 01c80b2)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 18, 2025

Copy link
Copy Markdown

GH-135655 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
freakboy3742 pushed a commit that referenced this pull request Jun 18, 2025
@miss-islington @hoodmane
[3.14] gh-127146: Enable large files on Emscripten (GH-135635) (#135655)
52cb287
Large files have been fully supported by Emscripten for a long time.
(cherry picked from commit 01c80b2)

Co-authored-by: Hood Chatham <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@hoodmane @lkollar
pythongh-127146: Enable large files on Emscripten (python#135635)
e85b7ad
Large files have been fully supported by Emscripten for a long time.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@hoodmane @Pranjal095
pythongh-127146: Enable large files on Emscripten (python#135635)
930ab1f
Large files have been fully supported by Emscripten for a long time.
@hoodmane
hoodmane deleted the emscripten-large-files branch July 23, 2025 09:43
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@hoodmane @taegyunkim
pythongh-127146: Enable large files on Emscripten (python#135635)
08ddd5f
Large files have been fully supported by Emscripten for a long time.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@hoodmane @Agent-Hellboy
pythongh-127146: Enable large files on Emscripten (python#135635)
c907ea4
Large files have been fully supported by Emscripten for a long time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@freakboy3742 freakboy3742

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hoodmane @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.