GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-119180: Only fetch globals and locals if necessary in `annotationlib.get_annotations()` by Viicos · Pull Request #135644 · python/cpython

Conversation

@Viicos

@Viicos Viicos commented Jun 17, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

A proposed small optimization. Best reviewed without whitespace: https://github.com/python/cpython/pull/135644/files?diff=split&w=1.

  • Issue: Implement PEP 649 and PEP 749 #119180

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Viicos
pythongh-119180: Only fetch globals and locals if necessary in `annot…
f8afd8e 
…ationlib.get_annotations()`
@Viicos
Viicos requested a review from JelleZijlstra as a code owner June 17, 2025 20:45
@bedevere-app bedevere-app Bot added the awaiting review label Jun 17, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 17, 2025
Implement PEP 649 and PEP 749 #119180
Closed
21 of 30 tasks
@ZeroIntensity ZeroIntensity added the topic-typing label Jun 18, 2025
@JelleZijlstra JelleZijlstra added the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
JelleZijlstra
JelleZijlstra approved these changes Jun 18, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 18, 2025
@JelleZijlstra
JelleZijlstra merged commit 504ae60 into python:main Jun 18, 2025
@miss-islington-app

miss-islington-app Bot commented Jun 18, 2025

Copy link
Copy Markdown

Thanks @Viicos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 18, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2025
@Viicos @miss-islington
pythongh-119180: Only fetch globals and locals if necessary in `annot…
6c317ec 
…ationlib.get_annotations()` (pythonGH-135644)

(cherry picked from commit 504ae60)

Co-authored-by: Victorien <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 18, 2025

Copy link
Copy Markdown

GH-135654 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
JelleZijlstra pushed a commit that referenced this pull request Jun 18, 2025
@miss-islington @Viicos
[3.14] gh-119180: Only fetch globals and locals if necessary in `anno…
1429eef 
…tationlib.get_annotations()` (GH-135644) (#135654)

gh-119180: Only fetch globals and locals if necessary in `annotationlib.get_annotations()` (GH-135644)
(cherry picked from commit 504ae60)

Co-authored-by: Victorien <[email protected]>
@Viicos
Viicos deleted the get-annotations-optimization branch June 18, 2025 09:03
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@Viicos @lkollar
pythongh-119180: Only fetch globals and locals if necessary in `annot…
2a004c3 
…ationlib.get_annotations()` (python#135644)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Viicos @Pranjal095
pythongh-119180: Only fetch globals and locals if necessary in `annot…
bb7dc09 
…ationlib.get_annotations()` (python#135644)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@Viicos @taegyunkim
pythongh-119180: Only fetch globals and locals if necessary in `annot…
8894a33 
…ationlib.get_annotations()` (python#135644)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@Viicos @Agent-Hellboy
pythongh-119180: Only fetch globals and locals if necessary in `annot…
09888f7 
…ationlib.get_annotations()` (python#135644)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Viicos @JelleZijlstra @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.