GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-135646: Raise consistent `NameError` exceptions in `ForwardRef.evaluate()` by Viicos · Pull Request #135663 · python/cpython

Conversation

@Viicos

@Viicos Viicos commented Jun 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The error message template hasn't changed in 25 years, so the risk of them going out of sync is quite low.

  • Issue: Raise consistent NameError in ForwardRef.evaluate() #135646

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Viicos
Viicos requested a review from JelleZijlstra as a code owner June 18, 2025 09:44
@bedevere-app bedevere-app Bot added the awaiting review label Jun 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 18, 2025
Raise consistent NameError in ForwardRef.evaluate() #135646
Closed
@Viicos
pythongh-135646: Raise consistent NameError exceptions in `ForwardR…
d28e0a9 
…ef.evaluate()`
@Viicos
Viicos force-pushed the evaluate-fr-nameerror branch from b4843e2 to d28e0a9 Compare June 18, 2025 09:48
JelleZijlstra
JelleZijlstra approved these changes Jun 18, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 18, 2025
@JelleZijlstra JelleZijlstra added the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
@JelleZijlstra
JelleZijlstra enabled auto-merge (squash) June 18, 2025 13:00
@JelleZijlstra
JelleZijlstra merged commit 343719d into python:main Jun 18, 2025
@miss-islington-app

miss-islington-app Bot commented Jun 18, 2025

Copy link
Copy Markdown

Thanks @Viicos for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 18, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 18, 2025
@Viicos @miss-islington
pythongh-135646: Raise consistent NameError exceptions in `ForwardR…
846c240 
…ef.evaluate()` (pythonGH-135663)

(cherry picked from commit 343719d)

Co-authored-by: Victorien <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 18, 2025

Copy link
Copy Markdown

GH-135673 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 18, 2025
JelleZijlstra pushed a commit that referenced this pull request Jun 18, 2025
@miss-islington @Viicos
[3.14] gh-135646: Raise consistent NameError exceptions in `Forward…
d4daf4d 
…Ref.evaluate()` (GH-135663) (#135673)

gh-135646: Raise consistent `NameError` exceptions in `ForwardRef.evaluate()` (GH-135663)
(cherry picked from commit 343719d)

Co-authored-by: Victorien <[email protected]>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@Viicos @lkollar
pythongh-135646: Raise consistent NameError exceptions in `ForwardR…
ec1acad 
…ef.evaluate()` (python#135663)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Viicos @Pranjal095
pythongh-135646: Raise consistent NameError exceptions in `ForwardR…
564d9b5 
…ef.evaluate()` (python#135663)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@Viicos @taegyunkim
pythongh-135646: Raise consistent NameError exceptions in `ForwardR…
f4d7ae3 
…ef.evaluate()` (python#135663)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@Viicos @Agent-Hellboy
pythongh-135646: Raise consistent NameError exceptions in `ForwardR…
9c729d1 
…ef.evaluate()` (python#135663)
@Viicos
Viicos deleted the evaluate-fr-nameerror branch October 20, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Viicos @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.