GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-135379: Add back const cast to _PyLong_IsCompact by Fidget-Spinner · Pull Request #135706 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Jun 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Top-of-stack caching in the JIT #135379

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
Add back const cast to _PyLong_IsCompact
991c098
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 19, 2025
@Fidget-Spinner
Fidget-Spinner requested a review from markshannon June 19, 2025 10:43
@Fidget-Spinner Fidget-Spinner added the skip news label Jun 19, 2025
@Fidget-Spinner Fidget-Spinner changed the title gh-135668: Add back const cast to _PyLong_IsCompact gh-135379: Add back const cast to _PyLong_IsCompact Jun 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 19, 2025
Top-of-stack caching in the JIT #135379
Closed
@Fidget-Spinner

Fidget-Spinner commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64 Debian root 3.x
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 19, 2025

Copy link
Copy Markdown

The regex 'AMD64 Debian root 3.x' did not match any buildbot builder. Is the requested builder in the list of stable builders?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner

Fidget-Spinner commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64 Debian root 3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 19, 2025

Copy link
Copy Markdown

The regex 'AMD64 Debian root 3' did not match any buildbot builder. Is the requested builder in the list of stable builders?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner

Fidget-Spinner commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64 CentOS9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 19, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 991c098 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135706%2Fmerge

The command will test the builders whose names match following regular expression: AMD64 CentOS9

The builders matched are:

  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 PR
  • AMD64 CentOS9 LTO PR
  • AMD64 CentOS9 LTO + PGO PR
  • AMD64 CentOS9 FIPS No Builtin Hashes PR
  • AMD64 CentOS9 NoGIL Refleaks PR
  • AMD64 CentOS9 NoGIL PR
  • AMD64 CentOS9 Refleaks PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
remove const
219d9d1
@Fidget-Spinner

Fidget-Spinner commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

!buildbot AMD64 CentOS9 NoGIL PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 19, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @Fidget-Spinner for commit 219d9d1 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135706%2Fmerge

The command will test the builders whose names match following regular expression: AMD64 CentOS9 NoGIL PR

The builders matched are:

  • AMD64 CentOS9 NoGIL PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner commented Jun 19, 2025
View reviewed changes
Comment thread Include/cpython/longintrepr.h

static inline int
PyLong_CheckCompact(const PyObject *op)
PyLong_CheckCompact(PyObject *op)

@Fidget-Spinner Fidget-Spinner Jun 19, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use PyObject * here because PyLong_CheckExact casts to PyObject * which discards the const qualifier.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@python python deleted a comment from murtazox04 Jun 19, 2025
@encukou
encukou merged commit 1b969f6 into python:main Jun 19, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 19, 2025
@Fidget-Spinner
Fidget-Spinner deleted the fix-const-cast branch June 19, 2025 12:17
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@Fidget-Spinner @lkollar
pythongh-135379: Add back const cast to _PyLong_IsCompact (pythonGH-1…
5ee00d3 
…35706)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Fidget-Spinner @Pranjal095
pythongh-135379: Add back const cast to _PyLong_IsCompact (pythonGH-1…
15ca4e1 
…35706)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@Fidget-Spinner @taegyunkim
pythongh-135379: Add back const cast to _PyLong_IsCompact (pythonGH-1…
977dd64 
…35706)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@Fidget-Spinner @Agent-Hellboy
pythongh-135379: Add back const cast to _PyLong_IsCompact (pythonGH-1…
04f0385 
…35706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Fidget-Spinner @bedevere-bot @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.