GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-135379: Move PyLong_CheckCompact to private header by Fidget-Spinner · Pull Request #135707 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Jun 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Top-of-stack caching in the JIT #135379

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
Move PyLong_CheckCompact to private header
9930928
@Fidget-Spinner
Fidget-Spinner requested a review from markshannon as a code owner June 19, 2025 12:20
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 19, 2025
Top-of-stack caching in the JIT #135379
Closed
@Fidget-Spinner Fidget-Spinner added skip news and removed awaiting core review labels Jun 19, 2025
@encukou

encukou commented Jun 19, 2025

Copy link
Copy Markdown
Member

Since you're moving/renaming it: should this be PyLong_CheckExactAndCompact, to reduce confusion with _PyLong_IsCompact/PyUnstable_Long_IsCompact?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner
rename
b23c39f
@Fidget-Spinner

Fidget-Spinner commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

Good point, I renamed it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou approved these changes Jun 19, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Jun 19, 2025
@Fidget-Spinner
Fidget-Spinner enabled auto-merge (squash) June 19, 2025 12:30
vstinner
vstinner approved these changes Jun 19, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fidget-Spinner
Fidget-Spinner merged commit 0243260 into python:main Jun 19, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 19, 2025
@Fidget-Spinner
Fidget-Spinner deleted the pylong_iscompact_private branch June 19, 2025 13:09
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@Fidget-Spinner @lkollar
pythongh-135379: Move PyLong_CheckCompact to private header and renam…
cebce46 
…e it (pythonGH-135707)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Fidget-Spinner @Pranjal095
pythongh-135379: Move PyLong_CheckCompact to private header and renam…
338e150 
…e it (pythonGH-135707)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@Fidget-Spinner @taegyunkim
pythongh-135379: Move PyLong_CheckCompact to private header and renam…
724adea 
…e it (pythonGH-135707)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@Fidget-Spinner @Agent-Hellboy
pythongh-135379: Move PyLong_CheckCompact to private header and renam…
68ad2d9 
…e it (pythonGH-135707)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@encukou encukou encukou approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Fidget-Spinner @encukou @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.