GeezerVison is showing github.com — gh-135379: fix MSVC warning: conversion from 'stwodigits' to 'digit' by chris-eibl · Pull Request #135714 · python/cpython
Conversation
chris-eibl
commented
Jun 19, 2025
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Fixes MSVC warning C4244: 'initializing': conversion from 'stwodigits' to 'digit', possible loss of data.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
'stwodigits' to 'digit', possible loss of data
chris-eibl
changed the title
gh-135379: fix MSVC warning C4244: 'initializing': conversion from 'stwodigits' to 'digit', possible loss of data
gh-135379: fix MSVC warning C4244: 'initializing': conversion from 'stwodigits' to 'digit'
Jun 19, 2025
chris-eibl
changed the title
gh-135379: fix MSVC warning C4244: 'initializing': conversion from 'stwodigits' to 'digit'
gh-135379: fix MSVC warning: conversion from 'stwodigits' to 'digit'
Jun 19, 2025
|
Just checking: what does the rest of longobject do? Sorry I cant check myself as Im on mobile
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
There are many (digit) casts if something is assigned to a digit, but is a bigger data type.
Here that cast is missing, hence, MSVC fires the warning. Which is of no concern, since a few lines above
if(!is_medium_int(x)) {
return PyStackRef_NULL;
}
ensures that the contents of stwodigits x is small enough to be cast into a digit without loss.
But since here a signed conversion takes place, too, I'd appreciate a second pair of eyes @markshannon ?
|
Fidget-Spinner reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
…igit' (pythonGH-135714)
fix warning C4244: 'initializing': conversion from
'stwodigits' to 'digit', possible loss of data
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
…igit' (pythonGH-135714)
fix warning C4244: 'initializing': conversion from
'stwodigits' to 'digit', possible loss of data
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…igit' (pythonGH-135714)
fix warning C4244: 'initializing': conversion from
'stwodigits' to 'digit', possible loss of data
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|