GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-135379: fix MSVC warning: conversion from 'stwodigits' to 'digit' by chris-eibl · Pull Request #135714 · python/cpython

Conversation

@chris-eibl

@chris-eibl chris-eibl commented Jun 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes MSVC warning C4244: 'initializing': conversion from 'stwodigits' to 'digit', possible loss of data.

  • Issue: Top-of-stack caching in the JIT #135379

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@chris-eibl
fix warning C4244: 'initializing': conversion from
18131ce
'stwodigits' to 'digit', possible loss of data
@bedevere-app bedevere-app Bot added the awaiting review label Jun 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 19, 2025
Top-of-stack caching in the JIT #135379
Closed
@chris-eibl chris-eibl added the skip news label Jun 19, 2025
@chris-eibl chris-eibl changed the title gh-135379: fix MSVC warning C4244: 'initializing': conversion from 'stwodigits' to 'digit', possible loss of data gh-135379: fix MSVC warning C4244: 'initializing': conversion from 'stwodigits' to 'digit' Jun 19, 2025
@chris-eibl chris-eibl changed the title gh-135379: fix MSVC warning C4244: 'initializing': conversion from 'stwodigits' to 'digit' gh-135379: fix MSVC warning: conversion from 'stwodigits' to 'digit' Jun 19, 2025
@Fidget-Spinner

Fidget-Spinner commented Jun 19, 2025

Copy link
Copy Markdown
Member

Just checking: what does the rest of longobject do? Sorry I cant check myself as Im on mobile

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chris-eibl

chris-eibl commented Jun 19, 2025

Copy link
Copy Markdown
Member Author

There are many (digit) casts if something is assigned to a digit, but is a bigger data type.

Here that cast is missing, hence, MSVC fires the warning. Which is of no concern, since a few lines above

    if(!is_medium_int(x)) {
        return PyStackRef_NULL;
    }

ensures that the contents of stwodigits x is small enough to be cast into a digit without loss.

But since here a signed conversion takes place, too, I'd appreciate a second pair of eyes @markshannon ?

Fidget-Spinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Fidget-Spinner
Fidget-Spinner approved these changes Jun 20, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 20, 2025
@Fidget-Spinner
Fidget-Spinner merged commit 8272660 into python:main Jun 20, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 20, 2025
@chris-eibl
chris-eibl deleted the fix_msvc_warning branch June 20, 2025 20:51
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@chris-eibl @Pranjal095
pythongh-135379: fix MSVC warning: conversion from 'stwodigits' to 'd…
152ca42
…igit' (pythonGH-135714)

fix warning C4244: 'initializing': conversion from

'stwodigits' to 'digit', possible loss of data
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@chris-eibl @taegyunkim
pythongh-135379: fix MSVC warning: conversion from 'stwodigits' to 'd…
a465a38
…igit' (pythonGH-135714)

fix warning C4244: 'initializing': conversion from

'stwodigits' to 'digit', possible loss of data
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@chris-eibl @Agent-Hellboy
pythongh-135379: fix MSVC warning: conversion from 'stwodigits' to 'd…
ecad01a
…igit' (pythonGH-135714)

fix warning C4244: 'initializing': conversion from

'stwodigits' to 'digit', possible loss of data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@chris-eibl @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.