GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127146: Skip test_os.test_mode for Emscripten by hoodmane · Pull Request #135764 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Jun 20, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This always fails in the build bot and always passes for me locally. Skip it for now in order to get the build bot running.

  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hoodmane
pythongh-127146: Skip test_os.test_mode for Emscripten
c6848ac
This always fails in the build bot and always passes for me
locally. Skip it for now in order to get the build bot running.
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Jun 20, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 20, 2025
Emscripten: Get test suite passing #127146
Closed
@hoodmane
hoodmane requested a review from freakboy3742 June 20, 2025 15:10
@hoodmane hoodmane added the skip news label Jun 20, 2025
@blockchainGuru1018

This comment was marked as spam.

Sign in to view
blockchainGuru1018
blockchainGuru1018 approved these changes Jun 20, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels Jun 20, 2025
@freakboy3742 freakboy3742 added the needs backport to 3.14 bugs and security fixes label Jun 21, 2025
freakboy3742
freakboy3742 approved these changes Jun 21, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logged #135783 to track the underlying problem once this is merged.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 21, 2025
freakboy3742
freakboy3742 reviewed Jun 21, 2025
View reviewed changes
Comment thread Lib/test/test_os.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742
Add reference to bug tracking the skip.
976e3c9
@freakboy3742
freakboy3742 enabled auto-merge (squash) June 21, 2025 05:28
@hoodmane

hoodmane commented Jun 21, 2025

Copy link
Copy Markdown
Contributor Author

Thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742
freakboy3742 merged commit f491125 into python:main Jun 21, 2025
@miss-islington-app

miss-islington-app Bot commented Jun 21, 2025

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 21, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 21, 2025
@hoodmane @miss-islington
pythongh-127146: Skip test_os.test_mode for Emscripten (pythonGH-135764)
e2bd638
Temporarily skip test_os.test_mode on Emscripten; this fails consistently
on the buildbot, but not on other test configurations. Reported as pythonGH-135783
for follow up.
(cherry picked from commit f491125)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 21, 2025

Copy link
Copy Markdown

GH-135784 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 21, 2025
freakboy3742 pushed a commit that referenced this pull request Jun 21, 2025
@miss-islington @hoodmane
[3.14] gh-127146: Skip test_os.test_mode for Emscripten (GH-135764) (#…
2b5c904
…135784)

Temporarily skip test_os.test_mode on Emscripten; this fails consistently
on the buildbot, but not on other test configurations. Reported as GH-135783
for follow up.
(cherry picked from commit f491125)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 21, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Android 3.14 (tier-3) has failed when building commit 2b5c904.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1794/builds/271) and take a look at the build logs.
  4. Check if the failure is related to this commit (2b5c904) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1794/builds/271

Summary of the results of the build (if available):

Click to see traceback logs
Traceback (most recent call last):
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/runners.py", line 118, in run
    return self._loop.run_until_complete(task)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/base_events.py", line 687, in run_until_complete
    return future.result()
           ^^^^^^^^^^^^^^^
  File "/Users/android/buildarea/3.14.mhsmith-android-aarch64/build/Android/android.py", line 597, in run_testbed
    async with asyncio.TaskGroup() as tg:
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/taskgroups.py", line 134, in __aexit__
    raise propagate_cancellation_error
  File "/Library/Frameworks/Python.framework/Versions/3.12/lib/python3.12/asyncio/taskgroups.py", line 110, in __aexit__
    await self._on_completed_fut
asyncio.exceptions.CancelledError
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@freakboy3742

freakboy3742 commented Jun 22, 2025

Copy link
Copy Markdown
Contributor

The Android failure is an unrelated issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@hoodmane @Pranjal095
pythongh-127146: Skip test_os.test_mode for Emscripten (python#135764)
1c1990b
Temporarily skip test_os.test_mode on Emscripten; this fails consistently
on the buildbot, but not on other test configurations. Reported as python#135783 
for follow up.
@hoodmane
hoodmane deleted the emscripten-xfail-mode branch July 15, 2025 14:53
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@hoodmane @taegyunkim
pythongh-127146: Skip test_os.test_mode for Emscripten (python#135764)
2cc5708
Temporarily skip test_os.test_mode on Emscripten; this fails consistently
on the buildbot, but not on other test configurations. Reported as python#135783 
for follow up.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@hoodmane @Agent-Hellboy
pythongh-127146: Skip test_os.test_mode for Emscripten (python#135764)
ed3aff8
Temporarily skip test_os.test_mode on Emscripten; this fails consistently
on the buildbot, but not on other test configurations. Reported as python#135783 
for follow up.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
+1 more reviewer
@blockchainGuru1018 blockchainGuru1018 blockchainGuru1018 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hoodmane @blockchainGuru1018 @bedevere-bot @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.