GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-135755: Use private names (_Py*) for header file guards new in 3.14 by encukou · Pull Request #135921 · python/cpython

Conversation

@encukou

@encukou encukou commented Jun 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

These are private; let's name new ones accordingly.

  • Issue: Undocumented 3.14 C API #135755

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@encukou
pythongh-135755: Use private names (_Py*) for header file guards new …
76adbad
…in 3.14

These are private API; let's name new ones accordingly.
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 25, 2025
Undocumented 3.14 C API #135755
Closed
39 tasks done
@encukou encukou added skip news needs backport to 3.14 bugs and security fixes labels Jun 25, 2025
@encukou
encukou merged commit 6be17ba into python:main Jun 26, 2025
@encukou
encukou deleted the private-header-guards branch June 26, 2025 11:05
@miss-islington-app

miss-islington-app Bot commented Jun 26, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 26, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2025
@encukou @miss-islington
pythongh-135755: Use private names (_Py*) for header file guards new …
f17714d
…in 3.14 (pythonGH-135921)

These are private API; let's name new ones accordingly.
(cherry picked from commit 6be17ba)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 26, 2025

Copy link
Copy Markdown

GH-135976 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2025
encukou added a commit that referenced this pull request Jul 1, 2025
@miss-islington @encukou
[3.14] gh-135755: Use private names (_Py*) for header file guards new…
665a682
… in 3.14 (GH-135921) (GH-135976)

These are private API; let's name new ones accordingly.
(cherry picked from commit 6be17ba)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 1, 2025

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.14 (tier-1) has failed when building commit 665a682.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1802/builds/251) and take a look at the build logs.
  4. Check if the failure is related to this commit (665a682) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1802/builds/251

Failed tests:

  • test_external_inspection

Failed subtests:

  • test_only_active_thread - test.test_external_inspection.TestGetStackTrace.test_only_active_thread

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.14.bolen-ubuntu/build/Lib/test/test_external_inspection.py", line 991, in test_only_active_thread
    self.assertEqual(len(gil_traces), 1, "Should have exactly one GIL holder")
    ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: 0 != 1 : Should have exactly one GIL holder
encukou reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@encukou @AndPuQing
pythongh-135755: Use private names (_Py*) for header file guards new …
8f8e6df
…in 3.14 (pythonGH-135921)

These are private API; let's name new ones accordingly.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou @Pranjal095
pythongh-135755: Use private names (_Py*) for header file guards new …
41ff8dd
…in 3.14 (pythonGH-135921)

These are private API; let's name new ones accordingly.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou @taegyunkim
pythongh-135755: Use private names (_Py*) for header file guards new …
d48eee5
…in 3.14 (pythonGH-135921)

These are private API; let's name new ones accordingly.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@encukou @Agent-Hellboy
pythongh-135755: Use private names (_Py*) for header file guards new …
34aed1e
…in 3.14 (pythonGH-135921)

These are private API; let's name new ones accordingly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.