GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-135755: Move SPECIAL_ constants to a private header by encukou · Pull Request #135922 · python/cpython

Conversation

@encukou

@encukou encukou commented Jun 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Macros without a Py/_Py prefix should not be defined in public headers.

These were added in #120640.

  • Issue: Undocumented 3.14 C API #135755

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-135755: Move SPECIAL_ constants to a private header
7c60af4 
Macros without a `Py`/`_Py` prefix should not be defined in public headers.
@encukou
encukou requested review from iritkatriel and markshannon as code owners June 25, 2025 09:55
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 25, 2025
Undocumented 3.14 C API #135755
Closed
39 tasks done
@encukou encukou added skip news needs backport to 3.14 bugs and security fixes labels Jun 25, 2025
@encukou encukou mentioned this pull request Jun 25, 2025
GH-120507: Lower the BEFORE_WITH and BEFORE_ASYNC_WITH instructions. #120640
Merged
iritkatriel
iritkatriel approved these changes Jun 25, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 25, 2025
@encukou
encukou merged commit 1b1ae82 into python:main Jun 25, 2025
@encukou
encukou deleted the special-names branch June 25, 2025 11:03
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 25, 2025
@miss-islington-app

miss-islington-app Bot commented Jun 25, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Jun 25, 2025

Copy link
Copy Markdown

Sorry, @encukou, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 1b1ae82fab0093924b8b89eb1c7eea11d7be7b18 3.14
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned encukou Jun 25, 2025
@encukou

encukou commented Jun 25, 2025

Copy link
Copy Markdown
Member Author

Thanks for the review!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Jun 25, 2025

Copy link
Copy Markdown

GH-135926 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 25, 2025
encukou added a commit to encukou/cpython that referenced this pull request Jun 25, 2025
@encukou
[3.14] pythongh-135755: Move SPECIAL_ constants to a private header (p…
45c38cc 
…ythonGH-135922)

Macros without a `Py`/`_Py` prefix should not be defined in public headers.
(cherry picked from commit 1b1ae82)

Co-authored-by: Petr Viktorin <[email protected]>
encukou added a commit that referenced this pull request Jun 25, 2025
@encukou
[3.14] gh-135755: Move SPECIAL_ constants to a private header (GH-135922
a345fed 
) (GH-135926)

Macros without a `Py`/`_Py` prefix should not be defined in public headers.
(cherry picked from commit 1b1ae82)
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@encukou @AndPuQing
pythongh-135755: Move SPECIAL_ constants to a private header (pythonG…
37b7efc 
…H-135922)

Macros without a `Py`/`_Py` prefix should not be defined in public headers.
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou @Pranjal095
pythongh-135755: Move SPECIAL_ constants to a private header (pythonG…
1d255b9 
…H-135922)

Macros without a `Py`/`_Py` prefix should not be defined in public headers.
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou @taegyunkim
pythongh-135755: Move SPECIAL_ constants to a private header (pythonG…
3f8eb52 
…H-135922)

Macros without a `Py`/`_Py` prefix should not be defined in public headers.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@encukou @Agent-Hellboy
pythongh-135755: Move SPECIAL_ constants to a private header (pythonG…
9033bd2 
…H-135922)

Macros without a `Py`/`_Py` prefix should not be defined in public headers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@encukou encukou

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.