GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-125206: Make _Py_FFI_SUPPORT_C_COMPLEX private by encukou · Pull Request #135932 · python/cpython

Conversation

@encukou

@encukou encukou commented Jun 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Users don't need this macro, and we don't want to document & support it. Right?

(We're not very consistent with configure macros, but we can start making things better with ones added in 3.14.)

  • Issue: CTypes test failed, complex double problem #125206

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@encukou
pythongh-125206: Make _Py_FFI_SUPPORT_C_COMPLEX private
4db18b6
@encukou
encukou requested review from corona10 and erlend-aasland as code owners June 25, 2025 11:58
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 25, 2025
@encukou encukou added skip news and removed awaiting core review labels Jun 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 25, 2025
CTypes test failed, complex double problem #125206
Closed
@encukou encukou mentioned this pull request Jun 25, 2025
Undocumented 3.14 C API #135755
Closed
39 tasks done
skirpichev
skirpichev approved these changes Jun 25, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 25, 2025
@encukou encukou added the needs backport to 3.14 bugs and security fixes label Jun 26, 2025
@encukou
encukou merged commit 9193efd into python:main Jun 26, 2025
@miss-islington-app

miss-islington-app Bot commented Jun 26, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 26, 2025
@encukou
encukou deleted the private-Py_FFI_SUPPORT_C_COMPLEX branch June 26, 2025 09:48
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2025
@encukou @miss-islington
pythongh-125206: Make _Py_FFI_SUPPORT_C_COMPLEX private (pythonGH-135932
9b9d02f
)

(cherry picked from commit 9193efd)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 26, 2025

Copy link
Copy Markdown

GH-135973 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2025
encukou added a commit that referenced this pull request Jun 26, 2025
@miss-islington @encukou
[3.14] gh-125206: Make _Py_FFI_SUPPORT_C_COMPLEX private (GH-135932) (G…
03711fb
…H-135973)

(cherry picked from commit 9193efd)

Co-authored-by: Petr Viktorin <[email protected]>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@encukou @AndPuQing
pythongh-125206: Make _Py_FFI_SUPPORT_C_COMPLEX private (pythonGH-135932
5f3f5f9
)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou @Pranjal095
pythongh-125206: Make _Py_FFI_SUPPORT_C_COMPLEX private (pythonGH-135932
8f8b5be
)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou @taegyunkim
pythongh-125206: Make _Py_FFI_SUPPORT_C_COMPLEX private (pythonGH-135932
98c64b6
)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@encukou @Agent-Hellboy
pythongh-125206: Make _Py_FFI_SUPPORT_C_COMPLEX private (pythonGH-135932
88df6ef
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skirpichev skirpichev skirpichev approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @skirpichev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.