GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-120713: Make _Py_NORMALIZE_CENTURY private by encukou · Pull Request #135933 · python/cpython

Conversation

@encukou

@encukou encukou commented Jun 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Users don't need this macro, and we don't want to document & support it. Right?

(We're not very consistent with configure macros, but we can start making things better with ones added in 3.14.)

  • Issue: datetime.strftime("%Y") is not padding correctly #120713

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-120713: Make _Py_NORMALIZE_CENTURY private
fc68cbc
@encukou
encukou requested review from abalkin, corona10, erlend-aasland and pganssle as code owners June 25, 2025 12:52
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 25, 2025
@encukou encukou added skip news and removed awaiting core review labels Jun 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 25, 2025
datetime.strftime("%Y") is not padding correctly #120713
Closed
encukou added 2 commits June 25, 2025 15:44
@encukou
Turn the __future__ table to list-table
55572d4 
This'll make it easier to add entries that need longer markup
@encukou
Semantic markup for __future__ feature descriptions
3e5a8f9
@encukou encukou mentioned this pull request Jun 26, 2025
Undocumented 3.14 C API #135755
Closed
39 tasks done
@serhiy-storchaka

serhiy-storchaka commented Jun 26, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

See also other approach in #128444 which allows to get rid of that macro.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the needs backport to 3.14 bugs and security fixes label Jun 26, 2025
@encukou

encukou commented Jun 26, 2025

Copy link
Copy Markdown
Member Author

Do you intend to backport #128444 to 3.14?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Jun 26, 2025

Copy link
Copy Markdown
Member

If it is reviewed and accepted. I do not risk to merge it without review.
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Jul 7, 2025

Copy link
Copy Markdown
Member Author

I'll merge this, and update the other PR(s) to remove the private macro.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou added 4 commits July 7, 2025 10:50
@encukou
Merge in the main branch; regenerate configure
5c91a4a
@encukou
Revert accidentally-pushed commit
83072af 
This reverts commit 3e5a8f9.
@encukou
Revert accidentally-pushed commit
44ad014 
This reverts commit 55572d4.
@encukou
Merge in the main branch
98f80c8
@encukou
encukou merged commit fb170cf into python:main Jul 7, 2025
@miss-islington-app

miss-islington-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou deleted the private-Py_NORMALIZE_CENTURY branch July 7, 2025 15:57
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2025
@encukou @miss-islington
pythongh-120713: Make _Py_NORMALIZE_CENTURY private (pythonGH-135933)
06720fd 
(cherry picked from commit fb170cf)

Co-authored-by: Petr Viktorin <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 7, 2025

Copy link
Copy Markdown

GH-136387 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 7, 2025
hugovk pushed a commit that referenced this pull request Jul 8, 2025
@miss-islington @encukou
[3.14] gh-120713: Make _Py_NORMALIZE_CENTURY private (GH-135933) (#13…
376e037 
…6387)

Co-authored-by: Petr Viktorin <[email protected]>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@encukou @AndPuQing
pythongh-120713: Make _Py_NORMALIZE_CENTURY private (pythonGH-135933)
8f7d86d
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@encukou @Pranjal095
pythongh-120713: Make _Py_NORMALIZE_CENTURY private (pythonGH-135933)
dc6ed76
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@encukou @picnixz
pythongh-120713: Make _Py_NORMALIZE_CENTURY private (pythonGH-135933)
0d1a69a
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@encukou @taegyunkim
pythongh-120713: Make _Py_NORMALIZE_CENTURY private (pythonGH-135933)
1ea68b8
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@encukou @Agent-Hellboy
pythongh-120713: Make _Py_NORMALIZE_CENTURY private (pythonGH-135933)
79668d7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.