GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-135755: Move `PyFunction_GET_BUILTINS` to the private API by ZeroIntensity · Pull Request #135938 · python/cpython

Conversation

@ZeroIntensity

@ZeroIntensity ZeroIntensity commented Jun 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is an alternative to GH-135934. It seems like it might be better to move this to the private API for a few reasons:

  1. There's no PyFunction_Get* equivalent for PyFunction_GET_BUILTINS.
  2. It's mostly untested, the only reference to it in the tests being in _testinternalcapi.
  • Issue: Undocumented 3.14 C API #135755

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZeroIntensity
Move PyFunction_GET_BUILTINS to the private API.
c054119
@ZeroIntensity
ZeroIntensity requested review from encukou and ericsnowcurrently June 25, 2025 14:08
@ZeroIntensity ZeroIntensity added skip news topic-C-API needs backport to 3.14 bugs and security fixes labels Jun 25, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 25, 2025
Undocumented 3.14 C API #135755
Closed
39 tasks done
ericsnowcurrently
ericsnowcurrently approved these changes Jun 25, 2025
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, making it internal makes sense.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 25, 2025
encukou
encukou approved these changes Jun 26, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
encukou merged commit 10a3d43 into python:main Jun 26, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 26, 2025
@miss-islington-app

miss-islington-app Bot commented Jun 26, 2025

Copy link
Copy Markdown

Thanks @ZeroIntensity for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 26, 2025
@ZeroIntensity @miss-islington
pythongh-135755: Move PyFunction_GET_BUILTINS to the private API (p…
e582c8b 
…ythonGH-135938)

(cherry picked from commit 10a3d43)

Co-authored-by: Peter Bierma <[email protected]>
@bedevere-app

bedevere-app Bot commented Jun 26, 2025

Copy link
Copy Markdown

GH-135972 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 26, 2025
@encukou encukou mentioned this pull request Jun 26, 2025
gh-135755: Document the new PyFunction_GET_BUILTINS macro #135934
Closed
encukou pushed a commit that referenced this pull request Jun 26, 2025
@miss-islington @ZeroIntensity
[3.14] gh-135755: Move PyFunction_GET_BUILTINS to the private API (G…
a797fe1 
…H-135938) (GH-135972)

(cherry picked from commit 10a3d43)

Co-authored-by: Peter Bierma <[email protected]>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@ZeroIntensity @AndPuQing
pythongh-135755: Move PyFunction_GET_BUILTINS to the private API (p…
55e0336 
…ythonGH-135938)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@ZeroIntensity @Pranjal095
pythongh-135755: Move PyFunction_GET_BUILTINS to the private API (p…
318bef6 
…ythonGH-135938)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@ZeroIntensity @taegyunkim
pythongh-135755: Move PyFunction_GET_BUILTINS to the private API (p…
2bcd352 
…ythonGH-135938)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@ZeroIntensity @Agent-Hellboy
pythongh-135755: Move PyFunction_GET_BUILTINS to the private API (p…
c25034d 
…ythonGH-135938)
@ZeroIntensity
ZeroIntensity deleted the private-get-builtins branch November 11, 2025 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ZeroIntensity @encukou @ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.