GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-134584: Eliminate redundant refcounting from ``_CALL_LEN`` by corona10 · Pull Request #136104 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Jun 29, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Eliminate redundant refcounting in the JIT #134584

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@corona10
pythongh-134584: Eliminate redundant refcounting from _CALL_LEN
6b2c10d
@corona10 corona10 added the skip news label Jun 29, 2025
@corona10
corona10 requested review from Fidget-Spinner, markshannon and tomasr8 as code owners June 29, 2025 15:53
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 29, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 29, 2025
Eliminate redundant refcounting in the JIT #134584
Closed
35 tasks done
@Fidget-Spinner

Fidget-Spinner commented Jun 29, 2025

Copy link
Copy Markdown
Member

Thanks! We need to wait until Mark's TOS caching PR is merged for this to be a speedup (I explained on the main issue), so lets wait for now.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 added 2 commits June 30, 2025 01:46
@corona10
more optmization
afd5bb0
@corona10
Revert "more optmization"
5e217c1 
This reverts commit afd5bb0.
Fidget-Spinner
Fidget-Spinner approved these changes Dec 11, 2025
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you please re-run make regen-cases on this after merging main in?

You can merge after.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Dec 11, 2025
Fidget-Spinner
Fidget-Spinner reviewed Dec 11, 2025
View reviewed changes
Comment thread Python/bytecodes.c Outdated
/* len(o) */
(void)null;
STAT_INC(CALL, hit);
INPUTS_DEAD();

@Fidget-Spinner Fidget-Spinner Dec 11, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved down to right before res = PyStackRef_FromPyObjectSteal(res_o);

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
corona10 added 2 commits December 11, 2025 23:36
@corona10
Merge remote-tracking branch 'upstream/main' into pythongh-134584
0f75899
@corona10
Address code review
34bbad9
Fidget-Spinner
Fidget-Spinner reviewed Dec 11, 2025
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@corona10

corona10 commented Dec 11, 2025

Copy link
Copy Markdown
Member Author

@Fidget-Spinner Done :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner

Fidget-Spinner commented Dec 11, 2025

Copy link
Copy Markdown
Member

@corona10 sorry I just noticed something else wrong, once you fix that you can merge. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
corona10 added 2 commits December 11, 2025 23:46
@corona10
Address code review
fd2c8e4
@corona10
fix
1daa038
@corona10
corona10 enabled auto-merge (squash) December 11, 2025 14:57
@corona10
corona10 merged commit a275385 into python:main Dec 11, 2025
68 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 11, 2025
@corona10
corona10 deleted the gh-134584 branch December 11, 2025 17:00
Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this pull request Dec 11, 2025
@Fidget-Spinner
Cleanups for refcount elimnation python#136104 and python#135860
f8d4df7
Fidget-Spinner added a commit to Fidget-Spinner/cpython that referenced this pull request Dec 11, 2025
@Fidget-Spinner
Cleanups for refcount elimnation python#136104 and python#135860
10f0bfa
@Fidget-Spinner Fidget-Spinner mentioned this pull request Dec 11, 2025
gh-134584: Cleanups for refcount elimination #135860 #142604
Merged
fatelei pushed a commit to fatelei/cpython that referenced this pull request Dec 12, 2025
@corona10 @fatelei
pythongh-134584: Eliminate redundant refcounting from _CALL_LEN (p…
1a6766e 
…ythongh-136104)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@tomasr8 tomasr8 Awaiting requested review from tomasr8 tomasr8 is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.