GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-136183: Deal with escapes in JIT optimizer's constant evaluator by Fidget-Spinner · Pull Request #136184 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Jul 1, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: The JIT's "pure" _BINARY_OP evaluation produces UB (and incorrect results) #136183

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Fidget-Spinner added 2 commits July 1, 2025 23:34
@Fidget-Spinner
JIT optimizer: Ignore escaping functions if inputs are pure
2daa0e4
@Fidget-Spinner
add a test
a78813d
@Fidget-Spinner
Fidget-Spinner requested a review from markshannon as a code owner July 1, 2025 15:38
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 1, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jul 1, 2025
The JIT's "pure" _BINARY_OP evaluation produces UB (and incorrect results) #136183
Closed
@Fidget-Spinner

Fidget-Spinner commented Jul 1, 2025

Copy link
Copy Markdown
Member Author

Skip news because no version of JIT has released with this yet.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fidget-Spinner Fidget-Spinner added the skip news label Jul 1, 2025
@Fidget-Spinner
Add test to cases generator
e648644
@Fidget-Spinner Fidget-Spinner changed the title gh-136183: Deal with escapes gh-136183: Deal with escapes in JIT optimizer's constant evaluator Jul 1, 2025
@Fidget-Spinner
Add executor_cases to CI triggers
75ad8b1
@Fidget-Spinner
Fidget-Spinner requested review from brandtbucher and savannahostrowski as code owners July 1, 2025 17:05
brandtbucher
brandtbucher approved these changes Jul 1, 2025
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this fixes the issues we've been seeing.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread .github/workflows/jit.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 1, 2025
@Fidget-Spinner
Address review
0724a09
@Fidget-Spinner
Fidget-Spinner merged commit b330897 into python:main Jul 2, 2025
@Fidget-Spinner
Fidget-Spinner deleted the deal-with-escapes branch July 2, 2025 06:08
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 2, 2025
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@Fidget-Spinner @AndPuQing
pythongh-136183: Deal with escapes in JIT optimizer's constant evalua…
811b391 
…tor (pythonGH-136184)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@Fidget-Spinner @Pranjal095
pythongh-136183: Deal with escapes in JIT optimizer's constant evalua…
c2d1ca8 
…tor (pythonGH-136184)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@Fidget-Spinner @picnixz
pythongh-136183: Deal with escapes in JIT optimizer's constant evalua…
52b868c 
…tor (pythonGH-136184)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@Fidget-Spinner @taegyunkim
pythongh-136183: Deal with escapes in JIT optimizer's constant evalua…
2ab40c0 
…tor (pythonGH-136184)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@Fidget-Spinner @Agent-Hellboy
pythongh-136183: Deal with escapes in JIT optimizer's constant evalua…
94d02f9 
…tor (pythonGH-136184)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Fidget-Spinner @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.