GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115999: remove redundant check in free-threading from `_STORE_ATTR_WITH_HINT` by kumaraditya303 · Pull Request #136249 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Jul 3, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Make the specializing interpreter thread-safe in --disable-gil builds #115999

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
remove redundant check
674a246
@kumaraditya303
kumaraditya303 requested a review from markshannon as a code owner July 3, 2025 16:01
@kumaraditya303 kumaraditya303 added the skip news label Jul 3, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 3, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jul 3, 2025
Make the specializing interpreter thread-safe in --disable-gil builds #115999
Closed
@kumaraditya303
kumaraditya303 requested a review from colesbury July 3, 2025 16:01
@kumaraditya303 kumaraditya303 added the topic-free-threading label Jul 3, 2025
@colesbury

colesbury commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

You'll need to run make regen-cases
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
make regen-cases
fb7523c
@kumaraditya303

kumaraditya303 commented Jul 3, 2025

Copy link
Copy Markdown
Contributor Author

You'll need to run make regen-cases

Sorry, missed that, fixed now
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury colesbury added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 3, 2025
@bedevere-bot

bedevere-bot commented Jul 3, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @colesbury for commit fb7523c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136249%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 3, 2025
colesbury
colesbury approved these changes Jul 3, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 3, 2025
@colesbury

colesbury commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

For posterity: we don't need to re-check _PyObject_GetManagedDict() because LOCK_OBJECT never blocks. If LOCK_OBJECT() blocked (and detached the thread state), then we would have problems because the quiescent state might mean that a replaced manage dictionary could be freed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 merged commit 85f092f into python:main Jul 4, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 4, 2025
@kumaraditya303
kumaraditya303 deleted the special branch July 4, 2025 03:34
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@kumaraditya303 @AndPuQing
pythongh-115999: remove redundant check in free-threading from `_STOR…
55a5b18 
…E_ATTR_WITH_HINT` (python#136249)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@kumaraditya303 @Pranjal095
pythongh-115999: remove redundant check in free-threading from `_STOR…
22fcb1b 
…E_ATTR_WITH_HINT` (python#136249)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@kumaraditya303 @picnixz
pythongh-115999: remove redundant check in free-threading from `_STOR…
809e892 
…E_ATTR_WITH_HINT` (python#136249)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@kumaraditya303 @taegyunkim
pythongh-115999: remove redundant check in free-threading from `_STOR…
fbbc3b8 
…E_ATTR_WITH_HINT` (python#136249)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@kumaraditya303 @Agent-Hellboy
pythongh-115999: remove redundant check in free-threading from `_STOR…
60864e7 
…E_ATTR_WITH_HINT` (python#136249)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kumaraditya303 @colesbury @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.