GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109700: fix memory error handling in `PyDict_SetDefault` by kumaraditya303 · Pull Request #136338 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Jul 6, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: test_interpreters: test_create_many_threaded() failed on FreeBSD: log: RuntimeError: interpreter creation failed #109700

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kumaraditya303
fix memory error
78b178a
@kumaraditya303
kumaraditya303 requested review from markshannon and methane as code owners July 6, 2025 13:58
@bedevere-app bedevere-app Bot mentioned this pull request Jul 6, 2025
test_interpreters: test_create_many_threaded() failed on FreeBSD: log: RuntimeError: interpreter creation failed #109700
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jul 6, 2025
@kumaraditya303
kumaraditya303 requested a review from serhiy-storchaka July 6, 2025 14:00
@kumaraditya303 kumaraditya303 added interpreter-core (Objects, Python, Grammar, and Parser dirs) needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Jul 6, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Jul 6, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jul 6, 2025
@blurb-it
📜🤖 Added by blurb_it.
cee9fa0
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) July 6, 2025 14:53
@kumaraditya303
kumaraditya303 merged commit d22e073 into python:main Jul 6, 2025
@miss-islington-app

miss-islington-app Bot commented Jul 6, 2025

Copy link
Copy Markdown

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 6, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 6, 2025
@kumaraditya303 @miss-islington
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
d62c8bc
…thonGH-136338)

(cherry picked from commit d22e073)

Co-authored-by: Kumar Aditya <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Jul 6, 2025

Copy link
Copy Markdown

Sorry, @kumaraditya303, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker d22e073d2b49313bbf42d40cbe74afa2b69385df 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington-app miss-islington-app Bot assigned kumaraditya303 Jul 6, 2025
@bedevere-app

bedevere-app Bot commented Jul 6, 2025

Copy link
Copy Markdown

GH-136340 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 6, 2025
kumaraditya303 added a commit that referenced this pull request Jul 6, 2025
@miss-islington @kumaraditya303
[3.14] gh-109700: fix memory error handling in PyDict_SetDefault (G…
5b65df7
…H-136338) (#136340)

gh-109700: fix memory error handling in `PyDict_SetDefault` (GH-136338)
(cherry picked from commit d22e073)

Co-authored-by: Kumar Aditya <[email protected]>
@kumaraditya303
kumaraditya303 deleted the dict branch July 6, 2025 17:20
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@kumaraditya303 @AndPuQing
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
3243ba1
…thon#136338)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@kumaraditya303 @Pranjal095
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
b07a9f0
…thon#136338)
picnixz pushed a commit to picnixz/cpython that referenced this pull request Jul 13, 2025
@kumaraditya303 @picnixz
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
6003abb
…thon#136338)
@bedevere-app

bedevere-app Bot commented Jul 14, 2025

Copy link
Copy Markdown

GH-136642 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Jul 14, 2025
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jul 14, 2025
@kumaraditya303
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
fb64ff8
…thon#136338)

(cherry picked from commit d22e073)
kumaraditya303 added a commit that referenced this pull request Jul 14, 2025
@kumaraditya303
[3.13] gh-109700: fix memory error handling in PyDict_SetDefault (#…
823bf76
…136338) (#136642)

gh-109700: fix memory error handling in `PyDict_SetDefault` (#136338)

(cherry picked from commit d22e073)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@kumaraditya303 @taegyunkim
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
5e650b1
…thon#136338)
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@kumaraditya303 @Agent-Hellboy
pythongh-109700: fix memory error handling in PyDict_SetDefault (py…
18ff217
…thon#136338)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@methane methane Awaiting requested review from methane methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kumaraditya303 kumaraditya303

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kumaraditya303 @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.