GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-91153: prevent a crash in `bytearray.__setitem__(ind, ...)` when `ind.__index__` has side-effects (GH-132379) by miss-islington · Pull Request #136581 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 12, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 5e1e21d)

Co-authored-by: Bast [email protected]
Co-authored-by: Bénédikt Tran [email protected]

  • Issue: UAF when writing to a bytearray with an element implementing __index__ with side-effects #91153

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bast0006 @picnixz @miss-islington
pythongh-91153: prevent a crash in bytearray.__setitem__(ind, ...) …
02aa323 
…when `ind.__index__` has side-effects (pythonGH-132379)

(cherry picked from commit 5e1e21d)

Co-authored-by: Bast <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Jul 12, 2025
This was referenced Jul 12, 2025
gh-91153: Fix bytearray holding a reference to its internal buffer when calling into potentially mutating __index__ methods #132379
Merged
UAF when writing to a bytearray with an element implementing __index__ with side-effects #91153
Closed
picnixz
picnixz approved these changes Jul 12, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 12, 2025
@picnixz
picnixz enabled auto-merge (squash) July 12, 2025 13:41
@picnixz
picnixz merged commit d5866a8 into python:3.14 Jul 12, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 12, 2025
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @bast0006
@picnixz @kumaraditya303
[3.14] pythongh-91153: prevent a crash in `bytearray.__setitem__(ind,…
4278eb4 
… ...)` when `ind.__index__` has side-effects (pythonGH-132379) (python#136581)

pythongh-91153: prevent a crash in `bytearray.__setitem__(ind, ...)` when `ind.__index__` has side-effects (pythonGH-132379)
(cherry picked from commit 5e1e21d)

Co-authored-by: Bast <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@miss-islington
miss-islington deleted the backport-5e1e21d-3.14 branch January 2, 2026 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @picnixz @bast0006
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.