GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127146: Emscripten: Make os.umask() actually work by hoodmane · Pull Request #136706 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Jul 16, 2025 •
edited by freakboy3742
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

At least when run in Node.

Fixes #135783.

umask still has a lot of issues, but will require upstream fixes in Emscripten.

  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-127146: Emscripten: Make os.umask() actually work
6b4911a 
At least when run in Node.
@bedevere-app bedevere-app Bot added the awaiting review label Jul 16, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jul 16, 2025
Emscripten: Get test suite passing #127146
Closed
@hoodmane hoodmane added the skip news label Jul 16, 2025
@freakboy3742 freakboy3742 added OS-emscripten needs backport to 3.14 bugs and security fixes labels Jul 16, 2025
@freakboy3742

freakboy3742 commented Jul 16, 2025

Copy link
Copy Markdown
Contributor

!buildbot emscripten
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 16, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 6b4911a 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136706%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
freakboy3742
freakboy3742 approved these changes Jul 16, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 16, 2025
@freakboy3742
freakboy3742 merged commit 12e52ca into python:main Jul 16, 2025
@miss-islington-app

miss-islington-app Bot commented Jul 16, 2025

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 16, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2025
@hoodmane @miss-islington
pythongh-127146: Emscripten: Make os.umask() actually work (pythonGH-…
fc2c113 
…136706)

Provide a stub implementation of umask that is enough to get some tests passing.
More work is needed upstream in Emscripten to make all umask tests to pass.
(cherry picked from commit 12e52ca)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 16, 2025

Copy link
Copy Markdown

GH-136711 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 16, 2025
freakboy3742 pushed a commit that referenced this pull request Jul 16, 2025
@miss-islington @hoodmane
[3.14] gh-127146: Emscripten: Make os.umask() actually work (GH-136706)…
4eee754 
… (#136711)

Provide a stub implementation of umask that is enough to get some tests passing.
More work is needed upstream in Emscripten to make all umask tests to pass.
(cherry picked from commit 12e52ca)

Co-authored-by: Hood Chatham <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@hoodmane @taegyunkim
pythongh-127146: Emscripten: Make os.umask() actually work (python#13…
c25d0cd 
…6706)

Provide a stub implementation of umask that is enough to get some tests passing.
More work is needed upstream in Emscripten to make all umask tests to pass.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@hoodmane @Agent-Hellboy
pythongh-127146: Emscripten: Make os.umask() actually work (python#13…
df3cc4c 
…6706)

Provide a stub implementation of umask that is enough to get some tests passing.
More work is needed upstream in Emscripten to make all umask tests to pass.
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @hoodmane @kumaraditya303
[3.14] pythongh-127146: Emscripten: Make os.umask() actually work (py…
e252b43 
…thonGH-136706) (python#136711)

Provide a stub implementation of umask that is enough to get some tests passing.
More work is needed upstream in Emscripten to make all umask tests to pass.
(cherry picked from commit 12e52ca)

Co-authored-by: Hood Chatham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

umasked os.makedirs() sometimes fails on Emscripten

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hoodmane @freakboy3742 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.