GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127146: Emscripten: more regular stack overflow skips by hoodmane · Pull Request #136708 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Jul 16, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In two places use skip_emscripten_stack_overflow instead of skipIf with an ad-hoc message. Also, make the skip_emscripten_stack_overflow message match wasi's message.

  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-127146: Emscripten: use skip_emscripten_stack_overflow inste…
8642a6c 
…ad of ad hoc skip

In two places. Also, make the skip_emscripten_stack_overflow message
match wasi's message.
@hoodmane hoodmane added skip news OS-emscripten labels Jul 16, 2025
@bedevere-app bedevere-app Bot added the awaiting review label Jul 16, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jul 16, 2025
Emscripten: Get test suite passing #127146
Closed
@hoodmane

hoodmane commented Jul 16, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot Emscripten
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 16, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 8642a6c 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136708%2Fmerge

The command will test the builders whose names match following regular expression: Emscripten

The builders matched are:

  • WASM Emscripten PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane
Fix
e74f523
freakboy3742
freakboy3742 approved these changes Jul 16, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 16, 2025
@freakboy3742 freakboy3742 added the needs backport to 3.14 bugs and security fixes label Jul 16, 2025
@freakboy3742
freakboy3742 enabled auto-merge (squash) July 16, 2025 13:43
@freakboy3742
freakboy3742 merged commit c730952 into python:main Jul 16, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 16, 2025
@miss-islington-app

miss-islington-app Bot commented Jul 16, 2025

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2025
@hoodmane @miss-islington
pythongh-127146: Emscripten: more regular stack overflow skips (pytho…
4bcd261 
…nGH-136708)

Makes the Emscripten stack overflow skip message consistent with WASI,
and replaces some ad-hoc skips.
(cherry picked from commit c730952)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 16, 2025

Copy link
Copy Markdown

GH-136712 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 16, 2025
freakboy3742 pushed a commit that referenced this pull request Jul 16, 2025
@miss-islington @hoodmane
[3.14] gh-127146: Emscripten: more regular stack overflow skips (GH-1…
ca6db4f 
…36708) (#136712)

Makes the Emscripten stack overflow skip message consistent with WASI,
and replaces some ad-hoc skips.
(cherry picked from commit c730952)

Co-authored-by: Hood Chatham <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@hoodmane @taegyunkim
pythongh-127146: Emscripten: more regular stack overflow skips (pytho…
0938289 
…n#136708)

Makes the Emscripten stack overflow skip message consistent with WASI, 
and replaces some ad-hoc skips.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@hoodmane @Agent-Hellboy
pythongh-127146: Emscripten: more regular stack overflow skips (pytho…
2d4d697 
…n#136708)

Makes the Emscripten stack overflow skip message consistent with WASI, 
and replaces some ad-hoc skips.
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @hoodmane @kumaraditya303
[3.14] pythongh-127146: Emscripten: more regular stack overflow skips (…
ec4a40d 
…pythonGH-136708) (python#136712)

Makes the Emscripten stack overflow skip message consistent with WASI,
and replaces some ad-hoc skips.
(cherry picked from commit c730952)

Co-authored-by: Hood Chatham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hoodmane @bedevere-bot @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.