GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-135148: Correctly handle f/t strings with comments and debug expressions (GH-135198) by miss-islington · Pull Request #136720 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 16, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit ef66fb5)

Co-authored-by: Pablo Galindo Salgado [email protected]

  • Issue: Parts of strings that look like comments being stripped out of nested strings with debug specifier #135148

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal @miss-islington
pythongh-135148: Correctly handle f/t strings with comments and debug…
c08f2ab 
… expressions (pythonGH-135198)

(cherry picked from commit ef66fb5)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@miss-islington
miss-islington requested review from lysnikolaou and pablogsal as code owners July 16, 2025 16:09
@bedevere-app bedevere-app Bot added the awaiting review label Jul 16, 2025
This was referenced Jul 16, 2025
Parts of strings that look like comments being stripped out of nested strings with debug specifier #135148
Closed
gh-135148: Correctly handle f/t strings with comments and debug expressions #135198
Merged
pablogsal
pablogsal approved these changes Jul 16, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 16, 2025
@pablogsal
pablogsal merged commit 9bf3464 into python:3.14 Jul 16, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 16, 2025
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @kumaraditya303
[3.14] pythongh-135148: Correctly handle f/t strings with comments an…
f671b96 
…d debug expressions (pythonGH-135198) (python#136720)
@miss-islington
miss-islington deleted the backport-ef66fb5-3.14 branch January 2, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.