GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127146: Emscripten: Set umask to zero in test_apropos_empty_doc by hoodmane · Pull Request #136740 · python/cpython

Conversation

@hoodmane

@hoodmane hoodmane commented Jul 17, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This fixes test_apropos_empty_doc. Much thanks to @freakboy3742 for the investigation.

  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hoodmane
pythongh-127146: Emscripten: Set umask to zero in python.sh
595781e 
We think this will fix `test_apropos_empty_doc`.
@hoodmane
hoodmane requested a review from freakboy3742 as a code owner July 17, 2025 12:42
@hoodmane hoodmane added skip news OS-emscripten labels Jul 17, 2025
@bedevere-app bedevere-app Bot added the awaiting review label Jul 17, 2025
@hoodmane

hoodmane commented Jul 17, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot emscripten
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Jul 17, 2025
Emscripten: Get test suite passing #127146
Closed
@bedevere-bot

bedevere-bot commented Jul 17, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 595781e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136740%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hoodmane

hoodmane commented Jul 17, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

So the test passes with a umask of 077 on native Python but fails with a umask of 077 in Emscripten Python. I will try to understand why.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hoodmane added 2 commits July 17, 2025 15:59
@hoodmane
Merge branch 'main' into emscripten-set-umask-zero
89144bf
@hoodmane
More specific fix
643e889
@hoodmane

hoodmane commented Jul 17, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot emscripten
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 17, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @hoodmane for commit 643e889 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136740%2Fmerge

The command will test the builders whose names match following regular expression: emscripten

The builders matched are:

  • WASM Emscripten PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742 freakboy3742 added the needs backport to 3.14 bugs and security fixes label Jul 17, 2025
freakboy3742
freakboy3742 approved these changes Jul 17, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 17, 2025
@freakboy3742
freakboy3742 enabled auto-merge (squash) July 17, 2025 15:12
@hoodmane hoodmane changed the title gh-127146: Emscripten: Set umask to zero in python.sh gh-127146: Emscripten: Set umask to zero in test_apropos_empty_doc Jul 17, 2025
@freakboy3742 freakboy3742 mentioned this pull request Jul 17, 2025
pydoc test_apropos_empty_doc test performs questionable chmod #136744
Closed
@freakboy3742
freakboy3742 merged commit 22af5d3 into python:main Jul 17, 2025
@miss-islington-app

miss-islington-app Bot commented Jul 17, 2025

Copy link
Copy Markdown

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 17, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 17, 2025
@hoodmane @miss-islington
pythongh-127146: Emscripten: Set umask to zero in python.sh (pythonGH…
3c629d6 
…-136740)

Clears the umask used during a test of pydoc.apropos when testing on
Emscripten. This is to work around a known issue in Emscripten; but it's not
clear if the chmod call that is causing the problem is actually testing
anything of significance.
(cherry picked from commit 22af5d3)

Co-authored-by: Hood Chatham <[email protected]>
@bedevere-app

bedevere-app Bot commented Jul 17, 2025

Copy link
Copy Markdown

GH-136745 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 17, 2025
freakboy3742 pushed a commit that referenced this pull request Jul 17, 2025
@miss-islington @hoodmane
[3.14] gh-127146: Emscripten: Set umask to zero in python.sh (GH-136740…
76d4a43 
…) (#136745)

Clears the umask used during a test of pydoc.apropos when testing on
Emscripten. This is to work around a known issue in Emscripten; but it's not
clear if the chmod call that is causing the problem is actually testing
anything of significance.
(cherry picked from commit 22af5d3)

Co-authored-by: Hood Chatham <[email protected]>
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@hoodmane @taegyunkim
pythongh-127146: Emscripten: Set umask to zero in python.sh (python#1…
811b7d9 
…36740)

Clears the umask used during a test of pydoc.apropos when testing on
Emscripten. This is to work around a known issue in Emscripten; but it's not
clear if the chmod call that is causing the problem is actually testing
anything of significance.
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@hoodmane @Agent-Hellboy
pythongh-127146: Emscripten: Set umask to zero in python.sh (python#1…
72d2fc3 
…36740)

Clears the umask used during a test of pydoc.apropos when testing on
Emscripten. This is to work around a known issue in Emscripten; but it's not
clear if the chmod call that is causing the problem is actually testing
anything of significance.
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @hoodmane @kumaraditya303
[3.14] pythongh-127146: Emscripten: Set umask to zero in python.sh (p…
2d179f9 
…ythonGH-136740) (python#136745)

Clears the umask used during a test of pydoc.apropos when testing on
Emscripten. This is to work around a known issue in Emscripten; but it's not
clear if the chmod call that is causing the problem is actually testing
anything of significance.
(cherry picked from commit 22af5d3)

Co-authored-by: Hood Chatham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-emscripten skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hoodmane @bedevere-bot @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.