GeezerVison

Original file line number	Diff line number	Diff line change
Expand Up		@@ -585,31 +585,31 @@ jobs:
		- name: Tests
		run: xvfb-run make ci

		build-tsan:
		name: >-
		Thread sanitizer
		${{ fromJSON(matrix.free-threading) && '(free-threading)' \|\| '' }}
		build-san:
		name: >- # ${{ '' } is a hack to nest jobs under the same sidebar category
		Sanitizers${{ '' }}
		needs: build-context
		if: needs.build-context.outputs.run-tests == 'true'
		strategy:
		fail-fast: false
		matrix:
		check-name:
		- Thread
		free-threading:
		- false
		- true
		uses: ./.github/workflows/reusable-tsan.yml
		sanitizer:
		- TSan
		include:
		- check-name: Undefined behavior
		sanitizer: UBSan
		free-threading: false
		uses: ./.github/workflows/reusable-san.yml
		with:
		sanitizer: ${{ matrix.sanitizer }}
		config_hash: ${{ needs.build-context.outputs.config-hash }}
		free-threading: ${{ matrix.free-threading }}

		build-ubsan:
		name: Undefined behavior sanitizer
		needs: build-context
		if: needs.build-context.outputs.run-tests == 'true'
		uses: ./.github/workflows/reusable-ubsan.yml
		with:
		config_hash: ${{ needs.build-context.outputs.config-hash }}

		cross-build-linux:
		name: Cross build Linux
		runs-on: ubuntu-latest
Expand Down Expand Up		@@ -708,7 +708,7 @@ jobs:
		- build-wasi
		- test-hypothesis
		- build-asan
		- build-tsan
		- build-san
		- cross-build-linux
		- cifuzz
		if: always()
Expand Down Expand Up		@@ -743,7 +743,7 @@ jobs:
		build-wasi,
		test-hypothesis,
		build-asan,
		build-tsan,
		build-san,
		cross-build-linux,
		'
		\|\| ''
Expand Down

124 changes: 124 additions & 0 deletions 124 .github/workflows/reusable-san.yml

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,124 @@
		name: Reusable Sanitizer

		on:
		workflow_call:
		inputs:
		sanitizer:
		required: true
		type: string
		config_hash:
		required: true
		type: string
		free-threading:
		description: Whether to use free-threaded mode
		required: false
		type: boolean
		default: false

		env:
		FORCE_COLOR: 1

		jobs:
		build-san-reusable:
		name: >-
		${{ inputs.sanitizer }}${{
		inputs.free-threading
		&& ' (free-threading)'
		\|\| ''
		}}
		runs-on: ubuntu-24.04
		timeout-minutes: 60
		steps:
		- uses: actions/checkout@v4
		with:
		persist-credentials: false
		- name: Runner image version
		run: echo "IMAGE_OS_VERSION=${ImageOS}-${ImageVersion}" >> "$GITHUB_ENV"
		- name: Restore config.cache
		uses: actions/cache@v4
		with:
		path: config.cache
		key: ${{ github.job }}-${{ env.IMAGE_OS_VERSION }}-${{ inputs.sanitizer }}-${{ inputs.config_hash }}
		- name: Install dependencies
		run: \|
		sudo ./.github/workflows/posix-deps-apt.sh
		# Install clang
		wget https://apt.llvm.org/llvm.sh
		chmod +x llvm.sh

		if [ "${SANITIZER}" = "TSan" ]; then
Comment thread webknjaz marked this conversation as resolved. Resolved Uh oh! There was an error while loading. Please reload this page.
		sudo ./llvm.sh 17 # gh-121946: llvm-18 package is temporarily broken
		sudo update-alternatives --install /usr/bin/clang clang /usr/bin/clang-17 100
		sudo update-alternatives --set clang /usr/bin/clang-17
		sudo update-alternatives --install /usr/bin/clang++ clang++ /usr/bin/clang++-17 100
		sudo update-alternatives --set clang++ /usr/bin/clang++-17
		# Reduce ASLR to avoid TSan crashing
		sudo sysctl -w vm.mmap_rnd_bits=28
		else
		sudo ./llvm.sh 20
		fi

		- name: Sanitizer option setup
		run: \|
		if [ "${SANITIZER}" = "TSan" ]; then
		echo "TSAN_OPTIONS=${SAN_LOG_OPTION} suppressions=${GITHUB_WORKSPACE}/Tools/tsan/suppressions${{
		fromJSON(inputs.free-threading)
		&& '_free_threading'
		\|\| ''
		}}.txt handle_segv=0" >> "$GITHUB_ENV"
		else
		echo "UBSAN_OPTIONS=${SAN_LOG_OPTION}" >> "$GITHUB_ENV"
		fi
		echo "CC=clang" >> "$GITHUB_ENV"
		echo "CXX=clang++" >> "$GITHUB_ENV"
		env:
		SANITIZER: ${{ inputs.sanitizer }}
		SAN_LOG_OPTION: log_path=${{ github.workspace }}/san_log
		- name: Add ccache to PATH
		run: \|
		echo "PATH=/usr/lib/ccache:$PATH" >> "$GITHUB_ENV"
		- name: Configure ccache action
		uses: hendrikmuhs/[email protected]
		with:
		save: ${{ github.event_name == 'push' }}
		max-size: "200M"
		- name: Configure CPython
		run: >-
		./configure
		--config-cache
		${{
		inputs.sanitizer == 'TSan'
		&& '--with-thread-sanitizer'
		\|\| '--with-undefined-behavior-sanitizer'
		}}
		--with-pydebug
		${{ fromJSON(inputs.free-threading) && '--disable-gil' \|\| '' }}
		- name: Build CPython
		run: make -j4
		- name: Display build info
		run: make pythoninfo
		- name: Tests
		run: >-
		./python -m test
		${{ inputs.sanitizer == 'TSan' && '--tsan' \|\| '' }}
		-j4
		- name: Parallel tests
		if: >-
		inputs.sanitizer == 'TSan'
		&& fromJSON(inputs.free-threading)
		run: ./python -m test --tsan-parallel --parallel-threads=4 -j4
		- name: Display logs
		if: always()
		run: find "${GITHUB_WORKSPACE}" -name 'san_log.*' \| xargs head -n 1000
		- name: Archive logs
		if: always()
		uses: actions/upload-artifact@v4
		with:
		name: >-
		${{ inputs.sanitizer }}-logs-${{
		fromJSON(inputs.free-threading)
		&& 'free-threading'
		\|\| 'default'
		}}
		path: san_log.*
		if-no-files-found: ignore

94 changes: 0 additions & 94 deletions 94 .github/workflows/reusable-tsan.yml

Show comments

View file

Open in desktop

This file was deleted.

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

74 changes: 0 additions & 74 deletions 74 .github/workflows/reusable-ubsan.yml

Show comments

View file

Open in desktop

This file was deleted.

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.