GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133296: Fix versionadded for C API functions that were backported by ngoldbaum · Pull Request #137024 · python/cpython

Conversation

@ngoldbaum

@ngoldbaum ngoldbaum commented Jul 22, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@hugovk asked me to update these docs on main to account for the late-breaking backport to 3.14.

📚 Documentation preview 📚: https://cpython-previews--137024.org.readthedocs.build/

  • Issue: Expose _PyCriticalSection_BeginMutex as a public API #133296

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@ngoldbaum
Fix versionadded for C API functions that were backported
57718cf
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Jul 22, 2025
@github-project-automation github-project-automation Bot added this to Docs PRs Jul 22, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Jul 22, 2025
@StanFromIreland StanFromIreland changed the title Fix versionadded for C API functions that were backported gh-133296: Fix versionadded for C API functions that were backported Jul 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jul 22, 2025
Expose _PyCriticalSection_BeginMutex as a public API #133296
Closed
ZeroIntensity
ZeroIntensity approved these changes Jul 22, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jul 22, 2025
AA-Turner
AA-Turner approved these changes Jul 22, 2025
View reviewed changes
@AA-Turner
AA-Turner merged commit b13a5df into python:main Jul 22, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jul 22, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Jul 22, 2025
hugovk
hugovk reviewed Jul 22, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst
* ``_Py_GetConfig()``: :c:func:`PyConfig_Get` and :c:func:`PyConfig_GetInt`
* ``_Py_HashBytes()``: :c:func:`Py_HashBuffer`
* ``_Py_fopen_obj()``: :c:func:`Py_fopen`
* ``PyMutex_IsLocked()`` : :c:func:`PyMutex_IsLocked`

@hugovk hugovk Jul 22, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the first one start with an underscore?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ZeroIntensity ZeroIntensity Jul 22, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, the private API lacked a leading underscore.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@hugovk hugovk Aug 7, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I need to undo my typo "fix" :)

#137525

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@ngoldbaum @taegyunkim
pythongh-133296: Fix versionadded for C API functions that were backp…
e8ac3bc 
…orted (python#137024)
@hugovk hugovk mentioned this pull request Aug 7, 2025
[3.14] gh-123299: Backport typo fixes in What's New in Python 3.14 #137525
Merged
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@ngoldbaum @Agent-Hellboy
pythongh-133296: Fix versionadded for C API functions that were backp…
c7606b5 
…orted (python#137024)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments
@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ngoldbaum @hugovk @AA-Turner @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.