GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||
GeezerVison is showing github.com — gh-136759: Rename lock.h to pylock.h by aisk · Pull Request #137041 · python/cpython Conversation
|
|
🤖 New build scheduled with the buildbot fleet by @colesbury for commit f265080 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137041%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I thought it would be good to review OSS code to see if there are any third-party projects that have a file "pylock.h", as we probably don't want to break those projects either. Fortunately I was not able to find anything that obviously conflicts. Pixar's OpenUSD repository does have a file that is name-equivalent on case-insensitive filesystems like NTFS on Windows: https://github.com/PixarAnimationStudios/OpenUSD/blob/d0d5c33d5655f206a02b58311efa841890fb3894/pxr/base/tf/pyLock.h. However, this file is only included as There were no matches on pypi.org data either. I ran the following ClickHouse query against the https://py-code.org data to verify that: This came back with every row having 0 count. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @aisk for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @aisk for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @aisk and @kumaraditya303, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Rename `lock.h` to `pylock.h` to avoid conflicts with headers of other projects. (cherry picked from commit ec02db5) Co-authored-by: AN Long <[email protected]>
|
GH-137072 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'll try to resolve the backport conflict for 3.13. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
GH-137075 is a backport of this pull request to the 3.13 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…GH-137041) (python#137075)" This reverts commit 74503ac.
Rename `lock.h` to `pylock.h` to avoid conflicts with headers of other projects.
Rename `lock.h` to `pylock.h` to avoid conflicts with headers of other projects.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.