GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-28315: Fixing wrong documentation by ultimatecoder · Pull Request #1372 · python/cpython

Conversation

@ultimatecoder

@ultimatecoder ultimatecoder commented May 2, 2017

Copy link
Copy Markdown
Contributor
  • Description: Fixing wrong documentation which was mentioning 'in ?' but the actual output in master branch gives 'in '.
  • Mailing list discussions: https://mail.python.org/mailman/private/core-mentorship/2016-October/003662.html
  • BPO: http://bugs.python.org/issue28315

@Mariatta Please review this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ultimatecoder
[IMPROVE] Improving documentation according to issue 28315.
63de6c4
@mention-bot

mention-bot commented May 2, 2017

Copy link
Copy Markdown

@ultimatecoder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @ezio-melotti and @benjaminp to be potential reviewers.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 2, 2017
@Mariatta Mariatta added the docs Documentation in the Doc dir label May 2, 2017
@Mariatta Mariatta self-assigned this May 2, 2017
Mariatta
Mariatta approved these changes May 3, 2017
View reviewed changes
@Mariatta
Mariatta merged commit 8856940 into python:master May 3, 2017
@Mariatta

Mariatta commented May 3, 2017

Copy link
Copy Markdown
Member

Thanks and congrats on your first contribution to CPython 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mariatta Mariatta added needs backport to 2.7 labels May 3, 2017
@ultimatecoder

ultimatecoder commented May 3, 2017

Copy link
Copy Markdown
Contributor Author

Thanks for your appreciation but this is not my first contribution to CPython. Few things had merged before :p
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request May 4, 2017
@ultimatecoder @Mariatta
[3.6] bpo-28315: Improve code examples in docs (pythonGH-1372)
eb54948 
Replace
   File "<stdin>", line 1, in ?
with
   File "<stdin>", line 1, in <module>
(cherry picked from commit 8856940)
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request May 4, 2017
@ultimatecoder @Mariatta
[3.5] bpo-28315: Improve code examples in docs (pythonGH-1372)
324d0de 
Replace
   File "<stdin>", line 1, in ?
with
   File "<stdin>", line 1, in <module>
(cherry picked from commit 8856940)
Mariatta added a commit that referenced this pull request May 4, 2017
@Mariatta
[3.5] bpo-28315: Improve code examples in docs (GH-1372) (#1446)
5274faf 
Replace
   File "<stdin>", line 1, in ?
with
   File "<stdin>", line 1, in <module>
(cherry picked from commit 8856940)
Mariatta added a commit that referenced this pull request May 4, 2017
@Mariatta
[3.6] bpo-28315: Improve code examples in docs (GH-1372) (#1445)
af71364 
Replace
   File "<stdin>", line 1, in ?
with
   File "<stdin>", line 1, in <module>
(cherry picked from commit 8856940)
@Mariatta Mariatta removed needs backport to 3.5 labels May 4, 2017
Mariatta pushed a commit to Mariatta/cpython that referenced this pull request May 4, 2017
@ultimatecoder @Mariatta
[2.7] bpo-28315: Improve code examples in docs (pythonGH-1372)
58f193f 
Replace
   File "<stdin>", line 1, in ?
with
   File "<stdin>", line 1, in <module>.
(cherry picked from commit 8856940)
@Mariatta Mariatta removed the needs backport to 2.7 label May 4, 2017
Mariatta added a commit that referenced this pull request May 4, 2017
@Mariatta
[2.7] bpo-28315: Improve code examples in docs (GH-1372) (#1447)
e1b02ff 
Replace
   File "<stdin>", line 1, in ?
with
   File "<stdin>", line 1, in <module>.
(cherry picked from commit 8856940)
@yan12125 yan12125 mentioned this pull request Jun 17, 2017
bpo-29442: Replace optparse with argparse in setup.py #139
Merged
@Mariatta Mariatta removed their assignment Jun 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ultimatecoder @mention-bot @Mariatta @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.