GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131876: Revert "gh-131876: extract `_hashlib` helpers into a separate directory (#136995) by picnixz · Pull Request #137307 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Aug 1, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 45138d3 until I'm able to make WASM work. It's annoying if people can't work on it because of that.

  • Issue: Unify recognization of message digest names for _hashlib and _hmac #131876

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
Revert "pythongh-131876: extract _hashlib helpers into a separate d…
4feb4d0 
…irectory (python#136995)"

This reverts commit 45138d3.
@bedevere-app bedevere-app Bot mentioned this pull request Aug 1, 2025
Unify recognization of message digest names for _hashlib and _hmac #131876
Open
@picnixz picnixz added the skip news label Aug 1, 2025
@picnixz

This comment was marked as resolved.

Sign in to view
@picnixz picnixz mentioned this pull request Aug 1, 2025
gh-131876: use extern storage for _hashlib helper functions #137301
Closed
@picnixz picnixz added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 1, 2025
@bedevere-bot

bedevere-bot commented Aug 1, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 4feb4d0 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137307%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 1, 2025
@picnixz
picnixz marked this pull request as ready for review August 1, 2025 16:09
@picnixz
picnixz requested review from a team, corona10, erlend-aasland, gpshead and tiran as code owners August 1, 2025 16:09
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 1, 2025
@picnixz
picnixz removed request for corona10, erlend-aasland and tiran August 1, 2025 16:09
gpshead
gpshead approved these changes Aug 1, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 1, 2025
@gpshead
gpshead merged commit fe0e921 into python:main Aug 1, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 1, 2025
@picnixz
picnixz deleted the fix/hashlib/revert-45138d35843297395b2d646f5391be108243957a branch August 1, 2025 17:45
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@picnixz @Agent-Hellboy
pythongh-131876: Revert "pythongh-131876: extract _hashlib helpers …
ef4a1fc 
…into a separate directory (python#136995) (python#137307)

Revert "pythongh-131876: extract `_hashlib` helpers into a separate directory (python#136995)"

This reverts commit 45138d3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @bedevere-bot @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.