GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132983: Fix docstrings in ZstdDict by Rogdham · Pull Request #137321 · python/cpython

Conversation

@Rogdham

@Rogdham Rogdham commented Aug 2, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes in docstrings:

  1. Remove extra " at the end of ZstdDict.as_prefix
  2. Fix dictionary,without being all glued together in ZstdDict.dict_id
  3. Add line returns to respect line length in ZstdDict.dict_id

Diff of help(ZstdDict) for illustration:
image

  • Issue: Implement PEP 784 - Adding Zstandard to the Python standard library #132983

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Rogdham
ZstdDict: fix docstrings
46855aa
@bedevere-app bedevere-app Bot added the awaiting review label Aug 2, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Aug 2, 2025
Implement PEP 784 - Adding Zstandard to the Python standard library #132983
Closed
13 tasks done
@Rogdham
Rogdham requested a review from ericsnowcurrently as a code owner August 2, 2025 09:25
@Rogdham
Run make regen-all
1739ffa
@Rogdham
Rogdham marked this pull request as draft August 2, 2025 09:28
@bedevere-app bedevere-app Bot removed the awaiting review label Aug 2, 2025
@StanFromIreland StanFromIreland added the skip news label Aug 2, 2025
@StanFromIreland
StanFromIreland requested a review from emmatyping August 2, 2025 09:29
@Rogdham
Revert "Run make regen-all" and run clinic instead
8447b65
picnixz
picnixz reviewed Aug 2, 2025
View reviewed changes
Comment thread Lib/compression/zstd/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Rogdham

Rogdham commented Aug 2, 2025

Copy link
Copy Markdown
Contributor Author

Sorry for the noise on this PR, I was having difficulties with clinic, but it should be ok now.

On an unrelated note, should this be backported to 3.14?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Rogdham
Rogdham marked this pull request as ready for review August 2, 2025 09:55
@bedevere-app bedevere-app Bot added the awaiting review label Aug 2, 2025
@picnixz picnixz added the needs backport to 3.14 bugs and security fixes label Aug 2, 2025
@picnixz

picnixz commented Aug 2, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Yeah, 3.14 is still in an RC1 phase and Zstd has been added for 3.14. So updating the docs etc should be part of 3.14. It doesn't make sense to wait for 3.15 to become the stable version before noticing those bugs.
Rogdham reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Rogdham
Revert changes in __init_.py
ebca5a9
picnixz
picnixz approved these changes Aug 2, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 2, 2025
emmatyping
emmatyping approved these changes Aug 2, 2025
View reviewed changes

@emmatyping emmatyping left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting these!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
aisk
aisk approved these changes Aug 2, 2025
View reviewed changes
serhiy-storchaka
serhiy-storchaka approved these changes Aug 3, 2025
View reviewed changes
AA-Turner
AA-Turner approved these changes Aug 3, 2025
View reviewed changes
Comment thread Modules/_zstd/zstddict.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_zstd/zstddict.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Rogdham
Apply Adam Turner suggestions
5d6a4ad
AA-Turner
AA-Turner approved these changes Aug 3, 2025
View reviewed changes

@AA-Turner AA-Turner left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rogdham for the future, you can use the "apply suggestion" button (or batched changes via the "files" tab), which can often be quicker, and has the benefit of automatically resolving the review comments.

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Rogdham reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@AA-Turner
AA-Turner enabled auto-merge (squash) August 3, 2025 14:45
@AA-Turner
AA-Turner merged commit 676748d into python:main Aug 3, 2025
@miss-islington-app

miss-islington-app Bot commented Aug 3, 2025

Copy link
Copy Markdown

Thanks @Rogdham for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 3, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 3, 2025
@Rogdham @AA-Turner @miss-islington
pythongh-132983: Fix docstrings in ZstdDict (pythonGH-137321)
6b906a9 
(cherry picked from commit 676748d)

Co-authored-by: Rogdham <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 3, 2025

Copy link
Copy Markdown

GH-137343 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 3, 2025
@Rogdham
Rogdham deleted the zstddict_fix_docstrings branch August 3, 2025 15:10
hugovk pushed a commit that referenced this pull request Aug 3, 2025
@miss-islington @Rogdham @AA-Turner
[3.14] gh-132983: Fix docstrings in ZstdDict (GH-137321) (#137343)
833d883 
Co-authored-by: Rogdham <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@Rogdham @AA-Turner @Agent-Hellboy
pythongh-132983: Fix docstrings in ZstdDict (python#137321)
bff2573 
Co-authored-by: Adam Turner <[email protected]>
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @Rogdham
@AA-Turner @kumaraditya303
[3.14] pythongh-132983: Fix docstrings in ZstdDict (pythonGH-137321…
f626b50 
…) (python#137343)

Co-authored-by: Rogdham <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aisk aisk aisk approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes
@emmatyping emmatyping emmatyping approved these changes
@picnixz picnixz picnixz approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Rogdham @picnixz @aisk @serhiy-storchaka @AA-Turner @emmatyping @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.