GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-137044: Support large limit values in getrlimit() and setrlimit() by serhiy-storchaka · Pull Request #137338 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 3, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Return large limit values as positive integers instead of negative integers in resource.getrlimit().
  • Accept large values and reject negative values (except RLIM_INFINITY) for limits in resource.setrlimit().
  • Issue: resource library (getrlimit, setrlimit) interprets resource limits as signed integers instead of unsigned #137044

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-137044: Support large limit values in getrlimit() and setrli…
3ad0cf0 
…mit()

* Return large limit values as positive integers instead of negative integers
  in resource.getrlimit().
* Accept large values and reject negative values (except RLIM_INFINITY)
  for limits in resource.setrlimit().
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Aug 3, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 3, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Aug 3, 2025
resource library (getrlimit, setrlimit) interprets resource limits as signed integers instead of unsigned #137044
Closed
serhiy-storchaka added 2 commits August 3, 2025 13:59
@serhiy-storchaka
Regenerate clinic files.
70a5e11
@serhiy-storchaka
Fix tests on macOS.
61592f4
@serhiy-storchaka

serhiy-storchaka commented Aug 3, 2025

Copy link
Copy Markdown
Member Author

!buildbot 32
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added 2 commits August 3, 2025 14:04
@serhiy-storchaka
Fix build on macOS.
4c0bf2c
@serhiy-storchaka
Fix tests on ASAN build.
7c1fea7
@serhiy-storchaka

serhiy-storchaka commented Aug 3, 2025

Copy link
Copy Markdown
Member Author

!buildbot 32
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Aug 3, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 7c1fea7 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137338%2Fmerge

The command will test the builders whose names match following regular expression: 32

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32-wasi PR
  • wasm32 WASI 8Core PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2025
@bedevere-bot

bedevere-bot commented Aug 6, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 7c1fea7 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137338%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2025
encukou
encukou reviewed Aug 6, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you! If the buildbots agree, please merge.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_resource.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka and others added 2 commits August 6, 2025 20:45
@serhiy-storchaka
Fix tests on FreeBSD and OpenIndiana.
a554136
@serhiy-storchaka @encukou
Update Lib/test/test_resource.py
4774421 
Co-authored-by: Petr Viktorin <[email protected]>
@serhiy-storchaka serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2025
@bedevere-bot

bedevere-bot commented Aug 6, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 4774421 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137338%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2025
@serhiy-storchaka
Try to fix tests on 32-bit Linux.
2446870
@serhiy-storchaka serhiy-storchaka added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2025
@bedevere-bot

bedevere-bot commented Aug 6, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @serhiy-storchaka for commit 2446870 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F137338%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 6, 2025
@serhiy-storchaka
serhiy-storchaka merged commit baefaa6 into python:main Aug 7, 2025
@miss-islington-app

miss-islington-app Bot commented Aug 7, 2025

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Aug 7, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 7, 2025
@serhiy-storchaka @miss-islington
pythongh-137044: Support large limit values in getrlimit() and setrli…
90f1437 
…mit() (pythonGH-137338)

* Return large limit values as positive integers instead of negative integers
  in resource.getrlimit().
* Accept large values and reject negative values (except RLIM_INFINITY)
  for limits in resource.setrlimit().
(cherry picked from commit baefaa6)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka
serhiy-storchaka deleted the resource-setrlimit-large branch August 7, 2025 08:06
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 7, 2025
@serhiy-storchaka @miss-islington
pythongh-137044: Support large limit values in getrlimit() and setrli…
64abcc3 
…mit() (pythonGH-137338)

* Return large limit values as positive integers instead of negative integers
  in resource.getrlimit().
* Accept large values and reject negative values (except RLIM_INFINITY)
  for limits in resource.setrlimit().
(cherry picked from commit baefaa6)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Aug 7, 2025

Copy link
Copy Markdown

GH-137506 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 7, 2025
@bedevere-app

bedevere-app Bot commented Aug 7, 2025

Copy link
Copy Markdown

GH-137507 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 7, 2025
serhiy-storchaka added a commit that referenced this pull request Aug 7, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-137044: Support large limit values in getrlimit() and setrl…
8905f7a 
…imit() (GH-137338) (GH-137507)

* Return large limit values as positive integers instead of negative integers
  in resource.getrlimit().
* Accept large values and reject negative values (except RLIM_INFINITY)
  for limits in resource.setrlimit().
(cherry picked from commit baefaa6)

Co-authored-by: Serhiy Storchaka <[email protected]>
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@serhiy-storchaka @Agent-Hellboy
pythongh-137044: Support large limit values in getrlimit() and setrli…
eaf36dd 
…mit() (pythonGH-137338)

* Return large limit values as positive integers instead of negative integers
  in resource.getrlimit().
* Accept large values and reject negative values (except RLIM_INFINITY)
  for limits in resource.setrlimit().
vstinner pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington @serhiy-storchaka
[3.14] gh-137044: Support large limit values in getrlimit() and setrl…
c4be405 
…imit() (GH-137338) (#137506)

gh-137044: Support large limit values in getrlimit() and setrlimit() (GH-137338)

* Return large limit values as positive integers instead of negative integers
  in resource.getrlimit().
* Accept large values and reject negative values (except RLIM_INFINITY)
  for limits in resource.setrlimit().
(cherry picked from commit baefaa6)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @bedevere-bot @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.