GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] GH-137426: Remove code deprecation of `importlib.abc.ResourceLoader` (GH-137567) by miss-islington · Pull Request #137654 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 11, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Enough other classes in importlib.abc inherit from the class and the deprecation was to redirect people to TraversableResources. The documentation now makes it clear the class only exists for backwards compatibility.

(cherry picked from commit 7140b99)

Co-authored-by: Brett Cannon [email protected]
Co-authored-by: Hugo van Kemenade [email protected]

  • Issue: importlib.abc.SourceLoader issues DeprecationWarning because it inherits from ResourceLoader #137426

📚 Documentation preview 📚: https://cpython-previews--137654.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brettcannon @hugovk @miss-islington
pythonGH-137426: Remove code deprecation of `importlib.abc.ResourceLo…
fb6a8fa 
…ader` (pythonGH-137567)

Enough other classes in `importlib.abc` inherit from the class and the deprecation was to redirect people to `TraversableResources`. The documentation now makes it clear the class only exists for backwards compatibility.

---------
(cherry picked from commit 7140b99)

Co-authored-by: Brett Cannon <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@miss-islington
miss-islington requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners August 11, 2025 23:19
@bedevere-app bedevere-app Bot added the awaiting review label Aug 11, 2025
This was referenced Aug 11, 2025
importlib.abc.SourceLoader issues DeprecationWarning because it inherits from ResourceLoader #137426
Closed
GH-137426: Remove code deprecation of importlib.abc.ResourceLoader #137567
Merged
@bedevere-app bedevere-app Bot added topic-importlib type-bug An unexpected behavior, bug, or error labels Aug 11, 2025
brettcannon
brettcannon approved these changes Aug 11, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 11, 2025
@brettcannon
brettcannon requested a review from hugovk August 11, 2025 23:19
@brettcannon

brettcannon commented Aug 11, 2025

Copy link
Copy Markdown
Member

@hugovk adding you for cherrypicking into 3.14.0rc2 .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Aug 12, 2025
View reviewed changes
@hugovk
hugovk merged commit daed07a into python:3.14 Aug 12, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 12, 2025
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @brettcannon
@hugovk @kumaraditya303
[3.14] pythonGH-137426: Remove code deprecation of `importlib.abc.Res…
1b5d9f2 
…ourceLoader` (pythonGH-137567) (python#137654)

Co-authored-by: Brett Cannon <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@miss-islington
miss-islington deleted the backport-7140b99-3.14 branch January 2, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@hugovk hugovk hugovk approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-importlib type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @brettcannon @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.