GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95534: Convert ``ZlibDecompressor.__new__`` to AC by AA-Turner · Pull Request #137923 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Aug 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Faster decompression of gzip files #95534

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Convert ZlibDecompressor.__new__ to AC
48c2acb
@AA-Turner
AA-Turner requested a review from picnixz August 18, 2025 19:33
@AA-Turner AA-Turner added the topic-argument-clinic label Aug 18, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 18, 2025
AA-Turner
AA-Turner commented Aug 18, 2025
View reviewed changes
Comment thread Modules/zlibmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Remove type as cls
12c7a0c
@AA-Turner AA-Turner added skip issue skip news labels Aug 18, 2025
@AA-Turner AA-Turner changed the title Convert ZlibDecompressor.__new__ to AC gh-95534: Convert ZlibDecompressor.__new__ to AC Aug 18, 2025
@AA-Turner AA-Turner removed the skip issue label Aug 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Aug 18, 2025
Faster decompression of gzip files #95534
Closed
picnixz
picnixz reviewed Aug 18, 2025
View reviewed changes
Comment thread Modules/zlibmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/zlibmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/zlibmodule.c
{Py_tp_new, ZlibDecompressor__new__},
{Py_tp_doc, (char *)ZlibDecompressor__new____doc__},
{Py_tp_new, zlib__ZlibDecompressor},
{Py_tp_doc, (char *)zlib__ZlibDecompressor__doc__},

@picnixz picnixz Aug 18, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something separate, but I think AC should give the possibility to create docstrings for class and module directives as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Modules/zlibmodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Tran's review
8a43485
@AA-Turner
AA-Turner requested a review from picnixz August 18, 2025 20:37
picnixz
picnixz approved these changes Aug 19, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 19, 2025
@AA-Turner
AA-Turner merged commit bb75dec into python:main Aug 19, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 19, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@AA-Turner @Agent-Hellboy
pythongh-95534: Convert ZlibDecompressor.__new__ to AC (python#13…
f80e241 
…7923)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-argument-clinic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AA-Turner @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.