GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-73487: Convert _decimal to use Argument Clinic (part 6) by skirpichev · Pull Request #138015 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Aug 21, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: decimal: Use Argument Clinic #73487

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@skirpichev
skirpichev requested a review from serhiy-storchaka August 21, 2025 04:41
@skirpichev skirpichev added skip news topic-argument-clinic labels Aug 21, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Aug 21, 2025
decimal: Use Argument Clinic #73487
Closed
@skirpichev
skirpichev marked this pull request as ready for review August 21, 2025 23:56
@skirpichev
skirpichev requested review from a team, AA-Turner and erlend-aasland as code owners August 21, 2025 23:56
@bedevere-app bedevere-app Bot added the awaiting review label Aug 21, 2025
@skirpichev
pythongh-73487: Convert _decimal to use Argument Clinic (part 6)
5a20bf0
@skirpichev
skirpichev force-pushed the ac-decimal/73487-pt6 branch from 903fcca to 5a20bf0 Compare August 22, 2025 01:29
serhiy-storchaka
serhiy-storchaka approved these changes Aug 22, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Modules/_decimal/_decimal.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 22, 2025
@skirpichev

skirpichev commented Aug 22, 2025

Copy link
Copy Markdown
Member Author

Docstrings diff:

--- ref.txt 2025-08-22 11:00:56.325746547 +0300
+++ patch.txt   2025-08-22 10:49:32.335072600 +0300
@@ -95,6 +95,8 @@
      |      traps=None
      |  )
      |
+     |  Create context.
+     |
      |  The context affects almost all operations and controls rounding,
      |  Over/Underflow, raising of exceptions and much more.  A new context
      |  can be constructed as follows:
@@ -182,12 +184,16 @@
      |      Copy the sign from y to x.
      |
      |  create_decimal(self, num='0', /)
-     |      Create a new Decimal instance from num, using self as the context. Unlike the
-     |      Decimal constructor, this function observes the context limits.
+     |      Create a new Decimal instance from num, using self as the context.
+     |
+     |      Unlike the Decimal constructor, this function observes the context
+     |      limits.
      |
      |  create_decimal_from_float(self, f, /)
-     |      Create a new Decimal instance from float f.  Unlike the Decimal.from_float()
-     |      class method, this function observes the context limits.
+     |      Create a new Decimal instance from float f.
+     |
+     |      Unlike the Decimal.from_float() class method, this function observes
+     |      the context limits.
      |
      |  divide(self, x, y, /)
      |      Return x divided by y.
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@encukou
encukou merged commit ef4dd1d into python:main Aug 28, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 28, 2025
@skirpichev
skirpichev deleted the ac-decimal/73487-pt6 branch August 28, 2025 10:44
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@skirpichev @lkollar
pythongh-73487: Convert _decimal to use Argument Clinic (part 6) (pyt…
1271d0c
…honGH-138015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-argument-clinic

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@skirpichev @serhiy-storchaka @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.