GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||
GeezerVison is showing github.com — gh-138013: Move test.test_io to be a module by cmaloney · Pull Request #138153 · python/cpython Conversation
|
The usual pattern is |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I was following what I saw in a couple instances (ex. test_string: https://github.com/python/cpython/blob/main/Lib/test/test_string/_support.py, test_zoneinfo: https://github.com/python/cpython/blob/main/Lib/test/test_zoneinfo/_support.py). There's also a couple of The IO Mocks are only useful for testing the two |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Another approach here would be to make a |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| # * test_memoryio - tests BytesIO and StringIO | ||
| # * test_fileio - tests FileIO | ||
| # * test_file - tests the file interface | ||
| # * test_io - tests everything else in the io module | ||
| # * test_io.test_general - tests everything else in the io module | ||
| # * test_univnewlines - tests universal newline support | ||
| # * test_largefile - tests operations on a file greater than 2**32 bytes |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Should the modules here be moved into the new package?
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
My plan is yes over time, just limiting scope of changes (and PRs) to pieces I'm actively working on changing (Currently Buffered I/O layer). test_bufio I plan to do as part of this overall issue (gh-138013). Not sure how much people rely on the names currently (ex. tracking performance over time by measuring test runtime). Unfortunately there are no benchmarks for CPython I/O in pyperformance currently (is part of my backlog to add).
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
The tests can and do move around, we don't make any guarantees here. Performance tests should use the pyperformance suite.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
If only useful within |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Could this get a skip news tag? (Test-only change) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.