GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-138158: Use the `"data"` tarfile extraction filter in `Tools/ssl/multissltests.py` (GH-138147) by miss-islington · Pull Request #138262 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 30, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The Tools/ssl/multissltests.py script may extract a possibly untrusted tarball.
Since the script does not necessarily use Python 3.14 or later (where the "data"
filter became the default tarfile extraction filter), the user may theoretically
suffer from a path traversal attack.

Although the script should not be used in production and usually relies on downloading
trusted sources, the "data" extraction filter is now explicitly used wherever relevant.
(cherry picked from commit 31d3836)

Co-authored-by: Tommaso Bona [email protected]

  • Issue: Fix Path Traversal in multissltests.py #138158

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ParzivalHack @miss-islington
pythongh-138158: Use the "data" tarfile extraction filter in `Tools…
543557c
…/ssl/multissltests.py` (pythonGH-138147)

The `Tools/ssl/multissltests.py` script may extract a possibly untrusted tarball.
Since the script does not necessarily use Python 3.14 or later (where the `"data"`
filter became the default `tarfile` extraction filter), the user may theoretically
suffer from a path traversal attack.

Although the script should not be used in production and usually relies on downloading
trusted sources, the `"data"` extraction filter is now explicitly used wherever relevant.
(cherry picked from commit 31d3836)

Co-authored-by: Tommaso Bona <[email protected]>
@miss-islington
miss-islington requested review from gpshead and picnixz as code owners August 30, 2025 10:27
@bedevere-app bedevere-app Bot added the awaiting review label Aug 30, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Aug 30, 2025
Fix Path Traversal in multissltests.py #138158
Closed
@bedevere-app bedevere-app Bot added skip news topic-SSL labels Aug 30, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Aug 30, 2025
gh-138158: Use the "data" tarfile extraction filter in Tools/ssl/multissltests.py #138147
Merged
picnixz
picnixz approved these changes Aug 30, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 30, 2025
@picnixz picnixz assigned hugovk Aug 30, 2025
@hugovk
hugovk merged commit b79bece into python:3.14 Aug 31, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 31, 2025
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @ParzivalHack @kumaraditya303
[3.14] pythongh-138158: Use the "data" tarfile extraction filter in…
b8e9bc5
… `Tools/ssl/multissltests.py` (pythonGH-138147) (python#138262)

Co-authored-by: Tommaso Bona <[email protected]>
@miss-islington
miss-islington deleted the backport-31d3836-3.14 branch January 2, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

skip news topic-SSL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @picnixz @hugovk @ParzivalHack
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.