GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116738: Fix test_json_mutating_exact_dict by eendebakpt · Pull Request #138339 · python/cpython

Conversation

@eendebakpt

@eendebakpt eendebakpt commented Sep 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The test intended to mutate the dict, but due to a missing key argument the dict was not changed.

  • Issue: Audit all built-in modules for thread safety #116738

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nineteendo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@eendebakpt
Fix test_json_mutating_exact_dict
6cdbe68
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 1, 2025
@eendebakpt eendebakpt added skip news and removed tests Tests in the Lib/test dir awaiting review labels Sep 1, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 1, 2025
Audit all built-in modules for thread safety #116738
Open
@eendebakpt eendebakpt mentioned this pull request Sep 1, 2025
gh-116738: Make _json module safe in the free-threading build #119438
Merged
kumaraditya303
kumaraditya303 approved these changes Sep 1, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Sep 1, 2025
@kumaraditya303
kumaraditya303 merged commit 0d02e4d into python:main Sep 1, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 1, 2025
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@eendebakpt @lkollar
pythongh-116738: Fix test_json_mutating_exact_dict (python#138339)
f009159 
Fix test_json_mutating_exact_dic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@eendebakpt @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.