GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-90548: Fix musl version detection with --strip-all (GH-137864) by miss-islington · Pull Request #138348 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 1, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 6528cf4)

Co-authored-by: Marc Mueller [email protected]
Co-authored-by: Adam Turner [email protected]

  • Issue: Multiple test failures on Alpine 3.15 / musl-1.2.2-r7 #90548

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cdce8p @AA-Turner @miss-islington
pythongh-90548: Fix musl version detection with --strip-all (pythonGH…
d14afe3 
…-137864)

(cherry picked from commit 6528cf4)

Co-authored-by: Marc Mueller <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Sep 1, 2025
This was referenced Sep 1, 2025
Multiple test failures on Alpine 3.15 / musl-1.2.2-r7 #90548
Closed
gh-90548: Fix musl version detection with --strip-all #137864
Merged
vstinner
vstinner approved these changes Sep 1, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 1, 2025
@cdce8p

cdce8p commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Thanks @vstinner! Looks like this one is ready for merge now, all checks have passed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 2, 2025

Copy link
Copy Markdown
Member

Thanks @vstinner! Looks like this one is ready for merge now, all checks have passed.

This fix will have to wait for Python 3.14.1. It's not special enough to fit into Python 3.14.0 final release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cdce8p

cdce8p commented Sep 2, 2025

Copy link
Copy Markdown
Contributor

Thanks @vstinner! Looks like this one is ready for merge now, all checks have passed.

This fix will have to wait for Python 3.14.1. It's not special enough to fit into Python 3.14.0 final release.

Ahh, I see. Tbh I had hoped it could still be included as it fixes a regression introduced in 6146295 (3.14.0a7). Without the fix I'll need to patch our alpine docker builds for 3.14.0.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 2, 2025

Copy link
Copy Markdown
Member

cc @hugovk
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zware zware assigned hugovk Sep 6, 2025
@hugovk
hugovk merged commit d36c9a8 into python:3.14 Sep 7, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 7, 2025
kumaraditya303 pushed a commit to miss-islington/cpython that referenced this pull request Sep 9, 2025
@miss-islington @cdce8p
@AA-Turner @kumaraditya303
[3.14] pythongh-90548: Fix musl version detection with --strip-all (p…
da5f681 
…ythonGH-137864) (python#138348)

Co-authored-by: Marc Mueller <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@miss-islington
miss-islington deleted the backport-6528cf4-3.14 branch January 2, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @cdce8p @vstinner @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.