GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-138013: Move I/O tests to test_io by cmaloney · Pull Request #138365 · python/cpython

Conversation

@cmaloney

@cmaloney cmaloney commented Sep 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Centralize io tests into the test_io module so they are easier to find and work on. This will make it easier to split test_general which takes 30+ seconds in a debug build on my machine.

This renames test_bufio to be test_bufferedio so that it matches the implementation file name (bufferedio.c).

Validation performed

Tests are run in parallel after change:

./python.exe -m test test_io  -uall,largefile,extralargefile -M12G -j8

Docstring reformat in test_io/__init__.py looks reasonable:

>>> import test.test_io
>>> help(test.test_io)
  • Issue: Move Buffered tests from test_io to test_bufio #138013

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cmaloney
pythongh-138013: Move I/O tests to test_io
ff31213 
Centralize `io` tests into the `test_io` module so they are easier to
find and work on. This will make it easier to split `test_general` which
takes 30+ seconds in a debug build on my machine.

This renames `test_bufio` to be `test_bufferedio` so that it matches
the implementation file name (`bufferedio.c`).

Validation performed:
Tests are run in parallel after change:
```bash
./python.exe -m test test_io  -uall,largefile,extralargefile -M12G -j8
```

Docstring reformat in `test_io/__init__.py` looks reasonable:
```python
>>> import test.test_io
>>> help(test.test_io)
```
@bedevere-app bedevere-app Bot added the awaiting review label Sep 1, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 1, 2025
Move Buffered tests from test_io to test_bufio #138013
Closed
@cmaloney
fix typo
f4f150e
@cmaloney

cmaloney commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

Can this get skip news as its a test only change?
ZeroIntensity reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity added tests Tests in the Lib/test dir skip news labels Sep 2, 2025
vstinner
vstinner approved these changes Sep 2, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cmaloney reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 2, 2025
AA-Turner
AA-Turner reviewed Sep 3, 2025
View reviewed changes
Comment thread Lib/test/test_io/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_io/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@cmaloney @AA-Turner
Apply suggestions from code review
b98448f 
Co-authored-by: Adam Turner <[email protected]>
AA-Turner
AA-Turner approved these changes Sep 3, 2025
View reviewed changes
@vstinner
vstinner merged commit 974532e into python:main Sep 3, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 3, 2025
@vstinner

vstinner commented Sep 3, 2025

Copy link
Copy Markdown
Member

Merged, thanks.
cmaloney reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cmaloney
cmaloney deleted the test_io_bufferedio branch September 3, 2025 16:49
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@cmaloney @AA-Turner @lkollar
pythongh-138013: Move I/O tests to test_io (python#138365)
e7247a9 
Centralize `io` tests into the `test_io` module so they are easier to
find and work on. This will make it easier to split `test_general` which
takes 30+ seconds in a debug build on my machine.

This renames `test_bufio` to be `test_bufferedio` so that it matches
the implementation file name (`bufferedio.c`).

Validation performed:
Tests are run in parallel after change:

```bash
./python.exe -m test test_io  -uall,largefile,extralargefile -M12G -j8
```

Docstring reformat in `test_io/__init__.py` looks reasonable:

```python
>>> import test.test_io
>>> help(test.test_io)
```

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@cmaloney @vstinner @AA-Turner @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.