GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127647: Fix and enable I/O protocol tests by srittau · Pull Request #138369 · python/cpython

Conversation

@srittau

@srittau srittau commented Sep 2, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Thanks, @cmaloney, for pointing this out!

  • Issue: Add simple Reader and Writer protocols #127647

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cmaloney reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@srittau
Fix and enable I/O protocol tests
e4e8b67
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 2, 2025
@srittau

srittau commented Sep 2, 2025

Copy link
Copy Markdown
Contributor Author

Cc @JelleZijlstra as merger of the original PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@srittau srittau changed the title gh-127648: Fix and enable I/O protocol tests gh-127647: Fix and enable I/O protocol tests Sep 2, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 2, 2025
Add simple Reader and Writer protocols #127647
Closed
@srittau srittau mentioned this pull request Sep 2, 2025
gh-127647: Add typing.Reader and Writer protocols #127648
Merged
@picnixz picnixz added the skip news label Sep 2, 2025
AA-Turner
AA-Turner approved these changes Sep 2, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 2, 2025
@AA-Turner AA-Turner added the needs backport to 3.14 bugs and security fixes label Sep 2, 2025
JelleZijlstra
JelleZijlstra approved these changes Sep 2, 2025
View reviewed changes
@JelleZijlstra
JelleZijlstra merged commit 3f23888 into python:main Sep 2, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 2, 2025
@miss-islington-app

miss-islington-app Bot commented Sep 2, 2025

Copy link
Copy Markdown

Thanks @srittau for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2025
@srittau @miss-islington
pythongh-127647: Fix and enable I/O protocol tests (pythonGH-138369)
93cb8e4 
(cherry picked from commit 3f23888)

Co-authored-by: Sebastian Rittau <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 2, 2025

Copy link
Copy Markdown

GH-138376 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 2, 2025
@srittau
srittau deleted the fix-io-protocol-tests branch September 2, 2025 20:28
@cmaloney cmaloney mentioned this pull request Sep 3, 2025
gh-138013: Move I/O test infrastructre to test_io.utils #138475
Merged
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@srittau @lkollar
pythongh-127647: Fix and enable I/O protocol tests (python#138369)
43d8a14
@cmaloney cmaloney mentioned this pull request Sep 10, 2025
gh-138013: Remove load_tests in test_io.test_general #138771
Merged
JelleZijlstra pushed a commit that referenced this pull request Oct 8, 2025
@miss-islington @srittau
[3.14] gh-127647: Fix and enable I/O protocol tests (GH-138369) (#138376
e104aad 
)

gh-127647: Fix and enable I/O protocol tests (GH-138369)
(cherry picked from commit 3f23888)

Co-authored-by: Sebastian Rittau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@srittau @JelleZijlstra @AA-Turner @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.