GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116738: test `dbm.gnu` module on FT Python build by yoney · Pull Request #138467 · python/cpython

Conversation

@yoney

@yoney yoney commented Sep 3, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#132749 added critical sections to the gnu.dbm object. This PR introduces multi-threaded tests for the dbm.gnu module.

cc: @mpage @colesbury @Yhg1s

  • Issue: Audit all built-in modules for thread safety #116738

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yoney
pythongh-116738: Test mdb.gnu module on FT Python build
f5f03ec
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Sep 3, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 3, 2025
Audit all built-in modules for thread safety #116738
Open
@yoney
yoney marked this pull request as ready for review September 3, 2025 18:15
@bedevere-app bedevere-app Bot added the awaiting review label Sep 3, 2025
@mpage
mpage requested review from Yhg1s, colesbury and mpage September 4, 2025 17:04
@mpage mpage added the skip news label Sep 4, 2025
@kumaraditya303 kumaraditya303 added the topic-free-threading label Sep 10, 2025
@kumaraditya303 kumaraditya303 changed the title gh-116738: Test mdb.gnu module on FT Python build gh-116738: test dbm.gnu module on FT Python build Oct 2, 2025
@kumaraditya303 kumaraditya303 added the needs backport to 3.14 bugs and security fixes label Oct 11, 2025
kumaraditya303
kumaraditya303 reviewed Oct 11, 2025
View reviewed changes
Comment thread Lib/test/test_free_threading/test_dbm_gnu.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@yoney
pythongh-116738: Use os_helper.temp_dir()
9a1c8ae
kumaraditya303
kumaraditya303 approved these changes Oct 12, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 12, 2025
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2025
@bedevere-bot

bedevere-bot commented Oct 12, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 9a1c8ae 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F138467%2Fmerge

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2025
@kumaraditya303
kumaraditya303 merged commit a18843d into python:main Oct 12, 2025
63 of 67 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Oct 12, 2025

Copy link
Copy Markdown

Thanks @yoney for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 12, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 12, 2025
@yoney @miss-islington
pythongh-116738: test dbm.gnu module on FT Python build (pythonGH-1…
916066c 
…38467)

(cherry picked from commit a18843d)

Co-authored-by: Alper <[email protected]>
@bedevere-app

bedevere-app Bot commented Oct 12, 2025

Copy link
Copy Markdown

GH-139987 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 12, 2025
kumaraditya303 pushed a commit that referenced this pull request Oct 12, 2025
@miss-islington @yoney
[3.14] gh-116738: test dbm.gnu module on FT Python build (GH-138467) (
6d6d02a 
#139987)

gh-116738: test `dbm.gnu` module on FT Python build (GH-138467)
(cherry picked from commit a18843d)

Co-authored-by: Alper <[email protected]>
@yoney
yoney deleted the ft_gdbm branch October 19, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@colesbury colesbury Awaiting requested review from colesbury
@Yhg1s Yhg1s Awaiting requested review from Yhg1s
@mpage mpage Awaiting requested review from mpage

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@yoney @bedevere-bot @kumaraditya303 @mpage
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.