GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-116738: Test resource module on FT Python build by yoney · Pull Request #138504 · python/cpython

Conversation

@yoney

@yoney yoney commented Sep 4, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The resource module appears thread-safe. According to Linux documentation, getrlimit(), setrlimit(), prlimit(), and getrusage() are marked as MT-Safe, and didn’t find any thread-safety issues mentioned for other docs (posix, freebsd).

  • Added a simple test for FT Python build to collect per-thread user time. This is only supported on some systems, like Linux.

cc: @mpage @colesbury @Yhg1s

  • Issue: Audit all built-in modules for thread safety #116738

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yoney
pythongh-116738: Test resource module on FT Python build
1caa970
@bedevere-app bedevere-app Bot mentioned this pull request Sep 4, 2025
Audit all built-in modules for thread safety #116738
Open
@StanFromIreland StanFromIreland added the skip news label Sep 4, 2025
@yoney
yoney marked this pull request as ready for review September 4, 2025 17:16
@bedevere-app bedevere-app Bot added the awaiting review label Sep 4, 2025
kumaraditya303
kumaraditya303 reviewed Sep 7, 2025
View reviewed changes
Comment thread Modules/resource.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@yoney
pythongh-116738: Remove pagesize() change
7ab0c23
kumaraditya303
kumaraditya303 approved these changes Sep 9, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 9, 2025
@kumaraditya303 kumaraditya303 added topic-free-threading needs backport to 3.14 bugs and security fixes labels Sep 10, 2025
@kumaraditya303
kumaraditya303 merged commit 32e1e06 into python:main Sep 11, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 11, 2025
@miss-islington-app

miss-islington-app Bot commented Sep 11, 2025

Copy link
Copy Markdown

Thanks @yoney for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2025
@yoney @miss-islington
pythongh-116738: add multi-threaded tests for resource module on fr…
421f864 
…ee-threading builds (pythonGH-138504)

(cherry picked from commit 32e1e06)

Co-authored-by: Alper <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 11, 2025

Copy link
Copy Markdown

GH-138793 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 11, 2025
kumaraditya303 added a commit that referenced this pull request Oct 7, 2025
@miss-islington @yoney @kumaraditya303
[3.14] gh-116738: add multi-threaded tests for resource module on f…
08673d8 
…ree-threading builds (GH-138504) (#138793)

gh-116738: add multi-threaded tests for `resource` module on free-threading builds (GH-138504)
(cherry picked from commit 32e1e06)

Co-authored-by: Alper <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
@yoney
yoney deleted the ft_resource branch October 19, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@yoney @kumaraditya303 @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.