GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103997: Remove incorrect statements about `-c` dedenting by StanFromIreland · Pull Request #138624 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Sep 7, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

@picnixz's preferred alternative to correcting (& testing fully) the behavior in #138620.

  • Issue: Auto dedent -c arguments #103997

📚 Documentation preview 📚: https://cpython-previews--138624.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@StanFromIreland
Remove incorrect comments instead
5e5c010
@StanFromIreland
StanFromIreland requested a review from picnixz September 7, 2025 16:15
@StanFromIreland
StanFromIreland requested a review from AA-Turner as a code owner September 7, 2025 16:15
@bedevere-app bedevere-app Bot added the awaiting review label Sep 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 7, 2025
Auto dedent -c arguments #103997
Closed
@picnixz picnixz added the skip news label Sep 7, 2025
picnixz
picnixz reviewed Sep 7, 2025
View reviewed changes
Comment thread Include/internal/pycore_unicodeobject.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Sep 7, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Review
adb7884
@StanFromIreland
StanFromIreland requested a review from picnixz September 7, 2025 16:57
picnixz
picnixz reviewed Sep 7, 2025
View reviewed changes
Comment thread Doc/using/cmdline.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/3.14.0b1.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland and others added 2 commits September 7, 2025 18:16
@StanFromIreland @picnixz
Apply suggestions from code review
af2a037 
Co-authored-by: Bénédikt Tran <[email protected]>
@StanFromIreland
Indent
690516e
@StanFromIreland
StanFromIreland requested a review from picnixz September 7, 2025 17:26
picnixz
picnixz approved these changes Sep 22, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better that way. Changing the dedent functions to mimic textwrap.dedent exactly is an overkill IMO and not worth the change at the C level.

@AA-Turner I'll let you check English.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 22, 2025
@StanFromIreland
Merge branch 'main' into remove-misleading-notes
41c3dc9
@StanFromIreland StanFromIreland mentioned this pull request Mar 7, 2026
gh-103997: Fix and test _PyUnicode_Dedent #138620
Closed
@StanFromIreland
StanFromIreland requested a review from methane March 7, 2026 14:09
encukou
encukou reviewed Mar 9, 2026
View reviewed changes

@encukou encukou left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the reference to textwrap.dedent, the new notes are weird.
What other characters than the ones used in Python's indentation should be considered?
How would have empty line been normalized otherwise?

I suggest removing the note in use-facing docs, and in the internals, mentioning textwrap.dedent as a base for the comparison.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.14.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/using/cmdline.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/3.14.0b1.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/unicodeobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Include/internal/pycore_unicodeobject.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland and others added 3 commits March 9, 2026 16:31
@StanFromIreland @encukou
Simplify
74b0259 
Co-authored-by: Petr Viktorin <[email protected]>
@StanFromIreland @encukou
Update Doc/using/cmdline.rst
df8ade1 
Co-authored-by: Petr Viktorin <[email protected]>
@StanFromIreland @encukou
Update Misc/NEWS.d/3.14.0b1.rst
121abc7 
Co-authored-by: Petr Viktorin <[email protected]>
@StanFromIreland
StanFromIreland requested a review from encukou March 9, 2026 16:33
encukou
encukou approved these changes Mar 10, 2026
View reviewed changes
@encukou
encukou merged commit bdf0105 into python:main Mar 10, 2026
50 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 10, 2026
@StanFromIreland
StanFromIreland deleted the remove-misleading-notes branch March 10, 2026 13:19
ljfp pushed a commit to ljfp/cpython that referenced this pull request Apr 25, 2026
@StanFromIreland @ljfp
pythongh-103997: Remove incorrect statements about -c dedenting (py…
3177ce5 
…thongh-138624)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@picnixz picnixz picnixz approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@methane methane Awaiting requested review from methane

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@StanFromIreland @encukou @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.