GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-138535: Pass directly state to posix fill_time() by vstinner · Pull Request #138693 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 9, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Pass directly the module state instead of passing the module to avoid a call to get_posix_state().

  • Issue: Optimize posixmodule.c:fill_time for typical timestamps #138535

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jbosboom reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@vstinner
pythongh-138535: Pass directly state to posix fill_time()
959e267 
Pass directly the module state instead of passing the module to avoid
a call to get_posix_state().
@vstinner vstinner added the skip news label Sep 9, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 9, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 9, 2025
Optimize posixmodule.c:fill_time for typical timestamps #138535
Closed
@vstinner
vstinner merged commit 6b7b9d0 into python:main Sep 9, 2025
@vstinner
vstinner deleted the fill_time_state branch September 9, 2025 14:31
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 9, 2025
lkollar pushed a commit to lkollar/cpython that referenced this pull request Sep 9, 2025
@vstinner @lkollar
pythongh-138535: Pass directly state to posix fill_time() (python#138693
8db209b 
)

Pass directly the module state instead of passing the module to avoid
a call to get_posix_state().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.