GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-138772: Add tests for Turtle.dot signature by JanEricNitschke · Pull Request #138773 · python/cpython

Conversation

@JanEricNitschke

@JanEricNitschke JanEricNitschke commented Sep 11, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR to add some tests/clarifications and possible docs for Turtle.dot().

  • Issue: Turtle dot function not accepting color parameter. #138772

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
adorilson reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Sep 11, 2025
@bedevere-app

This comment was marked as resolved.

Sign in to view
@bedevere-app bedevere-app Bot mentioned this pull request Sep 11, 2025
Turtle dot function not accepting color parameter. #138772
Closed
@aisk aisk added the skip news label Sep 11, 2025
@JanEricNitschke
Add tests for Turtle.dot signature
db943d1
@JanEricNitschke
JanEricNitschke force-pushed the test-turtle-dot branch from ff97561 to db943d1 Compare September 11, 2025 06:51
@serhiy-storchaka
serhiy-storchaka self-requested a review September 11, 2025 09:08
@JanEricNitschke
JanEricNitschke marked this pull request as ready for review September 11, 2025 13:50
@bedevere-app bedevere-app Bot added the awaiting review label Sep 11, 2025
@JanEricNitschke

JanEricNitschke commented Sep 11, 2025

Copy link
Copy Markdown
Contributor Author

I think the test failure is unrelated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland reviewed Sep 11, 2025
View reviewed changes
Comment thread Lib/test/test_turtle.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JanEricNitschke
Remove commented out lines in test
0a0cd10
serhiy-storchaka
serhiy-storchaka approved these changes Sep 25, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 25, 2025
@serhiy-storchaka
serhiy-storchaka merged commit 2462807 into python:main Sep 25, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 25, 2025
@serhiy-storchaka serhiy-storchaka added awaiting merge needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Sep 25, 2025
@miss-islington-app

miss-islington-app Bot commented Sep 25, 2025

Copy link
Copy Markdown

Thanks @JanEricNitschke for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Sep 25, 2025

Copy link
Copy Markdown

Thanks @JanEricNitschke for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 25, 2025
@JanEricNitschke @miss-islington
pythongh-138772: Add tests for Turtle.dot() signature (pythonGH-138773)
9859c9a 
(cherry picked from commit 2462807)

Co-authored-by: Jan-Eric Nitschke <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Sep 25, 2025

Copy link
Copy Markdown

Sorry, @JanEricNitschke and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 2462807b702d9a71f0bd73a6618d4948491852a0 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka Sep 25, 2025
@bedevere-app

bedevere-app Bot commented Sep 25, 2025

Copy link
Copy Markdown

GH-139326 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 25, 2025
@adorilson adorilson mentioned this pull request Sep 13, 2025
Create tests for turtle module #135272
Open
1 of 21 tasks
encukou pushed a commit that referenced this pull request Oct 7, 2025
@miss-islington @JanEricNitschke
[3.14] gh-138772: Add tests for Turtle.dot() signature (GH-138773) (G…
2de18f2 
…H-139326)

(cherry picked from commit 2462807)

Co-authored-by: Jan-Eric Nitschke <[email protected]>
@hugovk

hugovk commented Nov 4, 2025

Copy link
Copy Markdown
Member

@JanEricNitschke Would you like to have a go backporting this to 3.13? See #138773 (comment).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JanEricNitschke

JanEricNitschke commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

@hugovk Yes, let me have a look.

PR should then look like this one i assume: #139326
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Nov 4, 2025

Copy link
Copy Markdown
Member

Yes, that's right, after fixing a conflict 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JanEricNitschke added a commit to JanEricNitschke/cpython that referenced this pull request Nov 4, 2025
@JanEricNitschke
[3.13] pythongh-138772: Add tests for Turtle.dot() signature (pythonG…
b20464e 
…H-138773)

(cherry picked from commit 2462807)

Co-authored-by: Jan-Eric Nitschke <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 4, 2025

Copy link
Copy Markdown

GH-140992 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Nov 4, 2025
@JanEricNitschke

JanEricNitschke commented Nov 4, 2025

Copy link
Copy Markdown
Contributor Author

Created one, but not sure if i did it correctly by adding the whole test classes that were missing or if i should have just done the minimal changes instead.
hugovk reacted with thumbs up emoji hugovk reacted with eyes emoji
All reactions
  • 👍 1 reaction
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk added a commit that referenced this pull request Nov 5, 2025
@JanEricNitschke @hugovk
[3.13] gh-138772: Add tests for Turtle.dot() signature (GH-138773) (#…
15db242 
…140992)

Co-authored-by: Jan-Eric Nitschke <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@JanEricNitschke @hugovk @serhiy-storchaka @StanFromIreland @aisk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.