GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129813, PEP 782: Use PyBytesWriter in _io.FileIO.readall by cmaloney · Pull Request #138901 · python/cpython

Conversation

@cmaloney

@cmaloney cmaloney commented Sep 15, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Performance largely flat, maybe faster on bm_readall.py from gh-120754 (read all python docs and py files using readall).

$ pyperf compare_to main.json pep782.json
read_file_small: Mean +- std dev: [main] 5.71 us +- 0.05 us -> [pep782] 5.68 us +- 0.05 us: 1.01x faster
read_file_large: Mean +- std dev: [main] 89.7 us +- 0.9 us -> [pep782] 86.9 us +- 0.8 us: 1.03x faster
read_all_rst_bytes: Mean +- std dev: [main] 926 us +- 8 us -> [pep782] 920 us +- 12 us: 1.01x faster
read_all_rst_text: Mean +- std dev: [main] 2.24 ms +- 0.02 ms -> [pep782] 2.17 ms +- 0.04 ms: 1.03x faster

Benchmark hidden because not significant (1): read_all_py_bytes

Geometric mean: 1.01x faster
  • Issue: [C API] PEP 782: Add PyBytesWriter API #129813

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cmaloney
pythongh-129813, PEP 782: Use PyBytesWriter in _io.FileIO.readall
86b9f6b 
Performance about the same, using the benchmark from pythongh-120754:

```
pyperf compare_to main.json pep782.json
read_file_small: Mean +- std dev: [main] 5.71 us +- 0.05 us -> [pep782] 5.68 us +- 0.05 us: 1.01x faster
read_file_large: Mean +- std dev: [main] 89.7 us +- 0.9 us -> [pep782] 86.9 us +- 0.8 us: 1.03x faster
read_all_rst_bytes: Mean +- std dev: [main] 926 us +- 8 us -> [pep782] 920 us +- 12 us: 1.01x faster
read_all_rst_text: Mean +- std dev: [main] 2.24 ms +- 0.02 ms -> [pep782] 2.17 ms +- 0.04 ms: 1.03x faster

Benchmark hidden because not significant (1): read_all_py_bytes

Geometric mean: 1.01x faster
```
@bedevere-app bedevere-app Bot added the awaiting review label Sep 15, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 15, 2025
[C API] PEP 782: Add PyBytesWriter API #129813
Closed
@cmaloney
Fix MSVC C2036 warning by casting to char to match what PyBytes_AS_ST…
b644ffb 
…RING did
vstinner
vstinner reviewed Sep 15, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-09-14-18-21-17.gh-issue-129813.XN7EyU.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Sep 15, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I suggest removing the NEWS entry.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cmaloney reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 15, 2025
@vstinner vstinner added the skip news label Sep 15, 2025
@cmaloney
Remove News; no impact on end users
c6d5485
@vstinner
vstinner merged commit 71defb6 into python:main Sep 15, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 15, 2025
@cmaloney
cmaloney deleted the pep782_fileio branch September 15, 2025 20:40
@vstinner vstinner mentioned this pull request Sep 15, 2025
gh-129813, PEP 782: Use PyBytesWriter in _ssl #138929
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cmaloney @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.