GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||
GeezerVison is showing github.com — gh-135755: Make Py_TAIL_CALL_INTERP macro private by vstinner · Pull Request #138981 · python/cpython Conversation
|
|
@Fidget-Spinner: I blindly replaced |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks. I'll approve once CI passes. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I built Python with tail call on Linux using |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Don't worry, we have CI for the tail calling interpreter on most platforms, so you can just let it run :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ping @Fidget-Spinner |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@hugovk: This change mostly/only makes sense if it's backported to 3.14. Would you accept this late C API change in 3.14? It makes the macro private. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Maybe it's ok to leave the macro in 3.14 and remove it in 3.15. No one should rely on this macro :-) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @vstinner, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Rename Py_TAIL_CALL_INTERP to _Py_TAIL_CALL_INTERP. (cherry picked from commit 6504f20)
|
GH-139120 is a backport of this pull request to the 3.14 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Fidget-Spinner suggested me to merge this change in the main branch, so I did it :-) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.