GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — cross port importlib-metadata PR #76 by asottile · Pull Request #13903 · python/cpython

Conversation

@asottile

@asottile asottile commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

https://gitlab.com/python-devs/importlib_metadata/merge_requests/76

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asottile
cross port importlib-metadata PR python#76
f86c1a0 
https://gitlab.com/python-devs/importlib_metadata/merge_requests/76
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 7, 2019
@bedevere-bot bedevere-bot added the awaiting review label Jun 7, 2019
@asottile

asottile commented Jun 7, 2019

Copy link
Copy Markdown
Contributor Author

(needs backport to 3.8 only)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@warsaw warsaw added skip issue skip news needs backport to 3.8 and removed skip news labels Jun 7, 2019
@warsaw

warsaw commented Jun 7, 2019

Copy link
Copy Markdown
Member

@Mariatta Interesting buglet: If I add two labels at the same time (i.e. skip-news and skip-issue), it seems like the bot only gets one of them. I had to unapply skip-news and then reapply it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
warsaw
warsaw approved these changes Jun 7, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 7, 2019
@Mariatta

Mariatta commented Jun 7, 2019

Copy link
Copy Markdown
Member

Hmm this might be a GitHub related issue, a race condition of some sort..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@warsaw
warsaw merged commit 65e5860 into python:master Jun 7, 2019
@bedevere-bot

bedevere-bot commented Jun 7, 2019

Copy link
Copy Markdown

@warsaw: Please replace # with GH- in the commit message next time. Thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jun 7, 2019

Copy link
Copy Markdown
Contributor

Thanks @asottile for the PR, and @warsaw for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 7, 2019
@warsaw

warsaw commented Jun 7, 2019

Copy link
Copy Markdown
Member

Hmm this might be a GitHub related issue, a race condition of some sort..

Yeah, probably
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 7, 2019

Copy link
Copy Markdown

GH-13904 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Jun 7, 2019
miss-islington added a commit that referenced this pull request Jun 7, 2019
@miss-islington @asottile
cross port importlib-metadata PR GH-76 (GH-13903)
3b5bac2 
https://gitlab.com/python-devs/importlib_metadata/merge_requests/76
(cherry picked from commit 65e5860)

Co-authored-by: Anthony Sottile <[email protected]>
@asottile
asottile deleted the importlib_metadata_cross_port_PR_76 branch June 7, 2019 22:04
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@asottile @DinoV
cross port importlib-metadata PR python#76 (python#13903)
f54c885 
https://gitlab.com/python-devs/importlib_metadata/merge_requests/76
@jaraco jaraco mentioned this pull request Oct 22, 2020
Parse entry_points in a case-sensitive manner - [merged] python/importlib_metadata#204
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw warsaw approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@asottile @warsaw @Mariatta @bedevere-bot @miss-islington @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.