GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129813, PEP 782: Use PyBytesWriter in _socket by vstinner · Pull Request #139097 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Replace PyBytes_FromStringAndSize(NULL, size) and _PyBytes_Resize() with the new public PyBytesWriter API.

  • Issue: [C API] PEP 782: Add PyBytesWriter API #129813

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-129813, PEP 782: Use PyBytesWriter in _socket
f2b61a6
Replace PyBytes_FromStringAndSize(NULL, size) and _PyBytes_Resize()
with the new public PyBytesWriter API.
@vstinner vstinner added the skip news label Sep 18, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 18, 2025
[C API] PEP 782: Add PyBytesWriter API #129813
Closed
@vstinner

vstinner commented Sep 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Micro-benchmark:

import pyperf
import socket

s1, s2 = socket.socketpair()
loops = 100
size = 1

def func():
    s1.sendall(b'x' * (size * loops))
    for _ in range(loops):
        s = s2.recv(size)
        if len(s) != size:
            raise Exception

runner = pyperf.Runner()
runner.bench_func('bench', func, inner_loops=loops)

s1.close()
s2.close()

Result:

  • size=1: Mean +- std dev: [ref] 803 ns +- 12 ns -> [pep782] 769 ns +- 12 ns: 1.04x faster.
  • size=1_000: Mean +- std dev: [ref] 1.14 us +- 0.02 us -> [pep782] 1.15 us +- 0.03 us: 1.01x slower
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner
vstinner merged commit 4263bc3 into python:main Sep 18, 2025
@vstinner
vstinner deleted the pybyteswriter_socket branch September 18, 2025 09:20
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 18, 2025
@vstinner

vstinner commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

Another micro-benchmark:

import pyperf
import socket

s1, s2 = socket.socketpair()

def func(size):
    s1.sendall(b'x' * size)
    s = s2.recv(size)
    if len(s) != size:
        raise Exception

runner = pyperf.Runner()
for size in (1, 10, 100, 1000, 10_000, 100_000):
    runner.bench_func(f'recv {size:,}B', func, size)

s1.close()
s2.close()

Result:

Benchmark ref pep782
recv 1B 2.29 us 2.19 us: 1.05x faster
recv 10B 2.36 us 2.29 us: 1.03x faster
recv 100B 2.41 us 2.34 us: 1.03x faster
recv 1,000B 2.85 us 2.73 us: 1.04x faster
recv 10,000B 4.89 us 4.95 us: 1.01x slower
Geometric mean (ref) 1.02x faster

Benchmark hidden because not significant (1): recv 100,000B

The benchmark is not reliable :-( If I run it again, I get different result:

Benchmark ref pep782
recv 1B 2.22 us 2.17 us: 1.02x faster
recv 100B 2.27 us 2.33 us: 1.03x slower
recv 100,000B 25.0 us 25.2 us: 1.01x slower
Geometric mean (ref) 1.00x slower

Benchmark hidden because not significant (3): recv 10B, recv 1,000B, recv 10,000B

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner vstinner mentioned this pull request Sep 18, 2025
gh-129813, PEP 782: Use PyBytesWriter in _ssl #138929
Merged
@encukou

encukou commented Sep 19, 2025

Copy link
Copy Markdown
Member

This introduced some refleaks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Sep 19, 2025

Copy link
Copy Markdown
Member Author

This introduced some refleaks.

Ooops, thanks for the report! I wrote #139151 to fix it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.