GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118803: Improve documentation around `ByteString` deprecation by AlexWaygood · Pull Request #139115 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Sep 18, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

State more clearly why the ABC is scheduled for removal. State more clearly what the different options are that users should prefer instead.

  • Issue: Remove ByteString from typing and collections.abc #118803

📚 Documentation preview 📚: https://cpython-previews--139115.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
pythongh-118803: Improve documentation around ByteString deprecation
45fbbc6
@AlexWaygood
AlexWaygood requested review from AA-Turner, JelleZijlstra and rhettinger as code owners September 18, 2025 11:56
@AlexWaygood AlexWaygood added skip news needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes labels Sep 18, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 18, 2025
Remove ByteString from typing and collections.abc #118803
Closed
@AlexWaygood
AlexWaygood requested a review from hugovk September 18, 2025 12:38
hugovk
hugovk approved these changes Sep 18, 2025
View reviewed changes
Comment thread Doc/deprecations/pending-removal-in-3.17.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 18, 2025
@AlexWaygood
alphabetise
fb00877
AA-Turner
AA-Turner reviewed Sep 18, 2025
View reviewed changes
Comment thread Doc/deprecations/pending-removal-in-3.17.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/deprecations/pending-removal-in-3.17.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
Address Adam's feedback
58350a4
@AlexWaygood
AlexWaygood requested a review from AA-Turner September 18, 2025 15:08
AA-Turner
AA-Turner approved these changes Sep 18, 2025
View reviewed changes

@AA-Turner AA-Turner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is significantly better wording, thank you!

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@AlexWaygood
fix reference
7045889
@AlexWaygood
AlexWaygood enabled auto-merge (squash) September 18, 2025 17:04
@AlexWaygood
AlexWaygood merged commit 4305cc3 into python:main Sep 18, 2025
@AlexWaygood
AlexWaygood deleted the alex/bad-bytestring branch September 18, 2025 17:30
@miss-islington-app

miss-islington-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

Thanks @AlexWaygood for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 18, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 18, 2025
@AlexWaygood @miss-islington
pythongh-118803: Improve documentation around ByteString deprecation (
9835841 
pythonGH-139115)

(cherry picked from commit 4305cc3)

Co-authored-by: Alex Waygood <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

Sorry, @AlexWaygood, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4305cc3ef35a35f9b2c163ae0ffeea219da5af5d 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned AlexWaygood Sep 18, 2025
@bedevere-app

bedevere-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

GH-139136 is a backport of this pull request to the 3.14 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 18, 2025
hugovk pushed a commit that referenced this pull request Sep 18, 2025
@miss-islington @AlexWaygood
[3.14] gh-118803: Improve documentation around ByteString deprecati…
665a349 
…on (GH-139115) (#139136)

gh-118803: Improve documentation around `ByteString` deprecation (GH-139115)
(cherry picked from commit 4305cc3)

Co-authored-by: Alex Waygood <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 18, 2025

Copy link
Copy Markdown

GH-139137 is a backport of this pull request to the 3.13 branch.
AlexWaygood reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Sep 18, 2025
AlexWaygood added a commit that referenced this pull request Sep 18, 2025
@AlexWaygood
[3.13] gh-118803: Improve documentation around ByteString deprecati…
8246e25 
…on (#139115) (#139137)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AlexWaygood AlexWaygood

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @hugovk @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.