GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-139291: Fix C stack limits by factoring out finding hardware stack limits by markshannon · Pull Request #139294 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Sep 24, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Incorrect hard limit for stack protection for MacOS and TSAN #139291

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gpshead reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@markshannon
Fix C stack limits by factoring out finding hardware stack limits
8de23c0
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 24, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 24, 2025
Incorrect hard limit for stack protection for MacOS and TSAN #139291
Closed
@markshannon markshannon added the skip news label Sep 24, 2025
@markshannon

markshannon commented Sep 24, 2025

Copy link
Copy Markdown
Member Author

Skipping news as this is fixing issues in unreleased versions.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon markshannon mentioned this pull request Oct 7, 2025
gh-139653: Add PyUnstable_ThreadState_SetStackProtection() #139668
Merged
vstinner
vstinner approved these changes Oct 7, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 7, 2025
@encukou
encukou merged commit 7094f09 into python:main Oct 7, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 7, 2025
encukou pushed a commit to encukou/cpython that referenced this pull request Nov 17, 2025
@markshannon @encukou
pythonGH-139291: Fix C stack limits by factoring out finding hardware…
0300367 
… stack limits (pythonGH-139294)
@encukou encukou mentioned this pull request Nov 17, 2025
[3.14] gh-139653: Add PyUnstable_ThreadState_SetStackProtection() (GH-139668) #141661
Merged
hroncok pushed a commit to hroncok/cpython that referenced this pull request Nov 24, 2025
@markshannon @hroncok
pythonGH-139291: Fix C stack limits by factoring out finding hardware…
42e7abe 
… stack limits (pythonGH-139294)

(cherry picked from commit 7094f09)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@markshannon @vstinner @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.