GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-90949: Fix an "unused function" compiler warning introduced in GH-139234 by hartwork · Pull Request #139558 · python/cpython

Conversation

@hartwork

@hartwork hartwork commented Oct 4, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adds on top of #139368 to fix a compiler warning that did not exist prior to the work on #90949.

CC @picnixz

  • Issue: Expose Expat XML attack protection APIs #90949

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hartwork
pyexpat.c: Address compiler warning -Wunused-function
9d0b084 
The symptom was:
> ./Modules/pyexpat.c:202:1: warning: ‘set_invalid_arg’ defined but not used [-Wunused-function]
>   202 | set_invalid_arg(pyexpat_state *state, xmlparseobject *self, const char *errmsg)
>       | ^~~~~~~~~~~~~~~
@bedevere-app bedevere-app Bot mentioned this pull request Oct 4, 2025
Expose Expat XML attack protection APIs #90949
Closed
@bedevere-app bedevere-app Bot added the awaiting review label Oct 4, 2025
@picnixz picnixz changed the title gh-90949: Amend GH-139368 gh-90949: Fix an "unused function" compiler warning introduced in GH-139368 Oct 4, 2025
@picnixz picnixz added the skip news label Oct 4, 2025
@picnixz

picnixz commented Oct 4, 2025

Copy link
Copy Markdown
Member

I assume the compiler warning is "unused function" right?
hartwork reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz approved these changes Oct 4, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Oct 4, 2025
@hartwork

hartwork commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

I assume the compiler warning is "unused function" right?

@picnixz yes, I put details into the commit message.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Oct 4, 2025

Copy link
Copy Markdown
Member

Oups, I didn't see it. My bad. Thanks for the fix!
hartwork reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz changed the title gh-90949: Fix an "unused function" compiler warning introduced in GH-139368 gh-90949: Fix an "unused function" compiler warning introduced in GH-139234 Oct 4, 2025
@hartwork

hartwork commented Oct 4, 2025

Copy link
Copy Markdown
Contributor Author

@picnixz no worries, glad I could help. (The warning showed while working on the backports yesterday where the bundled Expat is not yet at >=2.7.2.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz enabled auto-merge (squash) October 4, 2025 14:02
@picnixz
picnixz merged commit fc48a3c into python:main Oct 4, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 4, 2025
danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
@hartwork @danigm
pythongh-90949: Fix an "unused function" compiler warning introduced in
1aead6b 
pythonGH-139234 (python#139558)

Fix a compiler warning `-Wunused-function` after f04bea4.

The `set_invalid_arg` function in `Modules/pyexpat.c` may be unused if the underlying Expat
version is less than 2.4.0.
@hartwork hartwork mentioned this pull request Dec 17, 2025
gh-90949: expose Expat API to tune exponential expansion protections #139368
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hartwork @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.