GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-70765: fix an HTTP/0.9 flaky test post GH-139514 by picnixz · Pull Request #139610 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Oct 5, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This fixes a flaky test on macOS (failure was observed in the backport to 3.13 and on #139607). I don't really know why the connection is reset on macOS while it's not on my Linux but the end result for HTTP/0.9 should be that the server neither replies or sends an empty content.

  • Issue: Bad BaseHTTPRequestHandler response when using HTTP/0.9 #70765

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
fix HTP/0.9 tests when the server is fast to close the connection
3e6b0b9
@picnixz picnixz added the skip news label Oct 5, 2025
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Oct 5, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 5, 2025
Bad BaseHTTPRequestHandler response when using HTTP/0.9 #70765
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 5, 2025
This was referenced Oct 5, 2025
gh-133951: Fix purelib packages not found in test_peg_generator TestCParser #139607
Merged
test_httpservers is flaky on macOS #139611
Closed
@picnixz
picnixz enabled auto-merge (squash) October 5, 2025 16:22
@picnixz
better suppression
96f3084
This was referenced Oct 5, 2025
[3.14] gh-70765: avoid waiting for HTTP headers when parsing HTTP/0.9 requests (GH-139514) #139600
Merged
[3.13] gh-70765: avoid waiting for HTTP headers when parsing HTTP/0.9 requests (GH-139514) #139602
Merged
@picnixz
picnixz merged commit 1fe89d3 into python:main Oct 5, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 5, 2025
@picnixz
picnixz deleted the fix/test/post-70765 branch October 5, 2025 17:15
danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
@picnixz @danigm
pythongh-70765: fix an HTTP/0.9 flaky test post pythonGH-139514 (pyth…
1998134 
…on#139610)

Fix a flaky test introduced in 13dc2fd.

After a single HTTP/0.9 request, both client and server are expected to
close the connection on their side. In particular, if a client sends two
requests with the same connection, only the first one should be handled.

In the tests, it might happen that checking for the second request to be
ignored did not take into account that the server may have already closed
the connection. This flaky behavior was first observed on macOS CI workers
but could not be reproduced locally on a Linux machine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.